From: Jakub Kicinski <kuba@kernel.org>
To: davem@davemloft.net, pabeni@redhat.com
Cc: edumazet@google.com, netdev@vger.kernel.org,
Jakub Kicinski <kuba@kernel.org>,
LinoSanfilippo@gmx.de
Subject: [PATCH net-next v2 07/15] slic: remove a copy of the NAPI_POLL_WEIGHT define
Date: Thu, 28 Apr 2022 14:23:15 -0700 [thread overview]
Message-ID: <20220428212323.104417-8-kuba@kernel.org> (raw)
In-Reply-To: <20220428212323.104417-1-kuba@kernel.org>
Defining local versions of NAPI_POLL_WEIGHT with the same
values in the drivers just makes refactoring harder.
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---
CC: LinoSanfilippo@gmx.de
---
drivers/net/ethernet/alacritech/slic.h | 2 --
drivers/net/ethernet/alacritech/slicoss.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/alacritech/slic.h b/drivers/net/ethernet/alacritech/slic.h
index 3add305d34b4..4eecbdfff3ff 100644
--- a/drivers/net/ethernet/alacritech/slic.h
+++ b/drivers/net/ethernet/alacritech/slic.h
@@ -265,8 +265,6 @@
#define SLIC_NUM_STAT_DESC_ARRAYS 4
#define SLIC_INVALID_STAT_DESC_IDX 0xffffffff
-#define SLIC_NAPI_WEIGHT 64
-
#define SLIC_UPR_LSTAT 0
#define SLIC_UPR_CONFIG 1
diff --git a/drivers/net/ethernet/alacritech/slicoss.c b/drivers/net/ethernet/alacritech/slicoss.c
index 1fc9a1cd3ef8..ce353b0c02a3 100644
--- a/drivers/net/ethernet/alacritech/slicoss.c
+++ b/drivers/net/ethernet/alacritech/slicoss.c
@@ -1803,7 +1803,7 @@ static int slic_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
goto unmap;
}
- netif_napi_add(dev, &sdev->napi, slic_poll, SLIC_NAPI_WEIGHT);
+ netif_napi_add(dev, &sdev->napi, slic_poll, NAPI_POLL_WEIGHT);
netif_carrier_off(dev);
err = register_netdev(dev);
--
2.34.1
next prev parent reply other threads:[~2022-04-28 21:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-28 21:23 [PATCH net-next v2 00/15] remove copies of the NAPI_POLL_WEIGHT define Jakub Kicinski
2022-04-28 21:23 ` [PATCH net-next v2 01/15] eth: " Jakub Kicinski
2022-04-29 8:11 ` Durrant, Paul
2022-04-28 21:23 ` [PATCH net-next v2 02/15] eth: smsc: remove a copy " Jakub Kicinski
2022-04-28 21:23 ` [PATCH net-next v2 03/15] eth: cpsw: " Jakub Kicinski
2022-04-28 21:23 ` [PATCH net-next v2 04/15] eth: pch_gbe: " Jakub Kicinski
2022-04-28 21:23 ` [PATCH net-next v2 05/15] eth: mtk_eth_soc: " Jakub Kicinski
2022-04-28 21:23 ` [PATCH net-next v2 06/15] usb: lan78xx: " Jakub Kicinski
2022-04-28 21:23 ` Jakub Kicinski [this message]
2022-04-28 21:47 ` Aw: [PATCH net-next v2 07/15] slic: " Lino Sanfilippo
2022-04-28 21:23 ` [PATCH net-next v2 08/15] net: bgmac: " Jakub Kicinski
2022-04-28 21:23 ` [PATCH net-next v2 09/15] eth: atlantic: " Jakub Kicinski
2022-04-28 21:23 ` [PATCH net-next v2 10/15] eth: benet: " Jakub Kicinski
2022-04-28 21:23 ` [PATCH net-next v2 11/15] eth: gfar: " Jakub Kicinski
2022-04-28 21:23 ` [PATCH net-next v2 12/15] eth: vxge: " Jakub Kicinski
2022-04-28 21:23 ` [PATCH net-next v2 13/15] eth: spider: " Jakub Kicinski
2022-04-28 21:23 ` [PATCH net-next v2 14/15] eth: velocity: " Jakub Kicinski
2022-04-28 21:23 ` [PATCH net-next v2 15/15] qeth: " Jakub Kicinski
2022-04-29 7:39 ` Alexandra Winter
2022-04-29 11:00 ` [PATCH net-next v2 00/15] remove copies " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220428212323.104417-8-kuba@kernel.org \
--to=kuba@kernel.org \
--cc=LinoSanfilippo@gmx.de \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).