From: Jakub Kicinski <kuba@kernel.org>
To: Bin Chen <bin.chen@corigine.com>
Cc: Simon Horman <simon.horman@corigine.com>,
David Miller <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
oss-drivers <oss-drivers@corigine.com>
Subject: Re: [PATCH net-next] nfp: VF rate limit support
Date: Fri, 29 Apr 2022 11:03:47 -0700 [thread overview]
Message-ID: <20220429110347.1d563c7b@kernel.org> (raw)
In-Reply-To: <SA1PR13MB5491A2994E4170BA33CCB7CEECFC9@SA1PR13MB5491.namprd13.prod.outlook.com>
On Fri, 29 Apr 2022 08:54:53 +0000 Bin Chen wrote:
> On Tue, 26 Apr 2022 7:53 AM, Jakub wrote:
> > On Fri, 22 Apr 2022 15:19:45 +0200 Simon Horman wrote:
> > > + if (max_tx_rate > 0 || min_tx_rate > 0) {
> > > + if (max_tx_rate > 0 && max_tx_rate < min_tx_rate) {
> > > + nfp_warn(app->cpp, "min-tx-rate exceeds max_tx_rate.\n");
> > > + return -EINVAL;
> > > + }
> >
> > This check should be moved to the core, I reckon.
> >
> We agree with your suggestion, thanks. We plan to do this in two steps:
> 1.The firmware that currently support this feature will reject the nonzero min_tx_rate configuration, so the check here will not step in. We will remove the check from driver site and upstream the patch.
> 2.We will do more investigation jobs and add an appropriate check in the core.
> What do you think?
Sorry, I meant the second part of the condition only, basically
something like:
next prev parent reply other threads:[~2022-04-29 18:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 13:19 [PATCH net-next] nfp: VF rate limit support Simon Horman
2022-04-25 23:53 ` Jakub Kicinski
2022-04-29 8:54 ` Bin Chen
2022-04-29 18:03 ` Jakub Kicinski [this message]
2022-04-29 18:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220429110347.1d563c7b@kernel.org \
--to=kuba@kernel.org \
--cc=bin.chen@corigine.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=oss-drivers@corigine.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).