From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C819BC433F5 for ; Fri, 29 Apr 2022 16:47:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1379291AbiD2QuY (ORCPT ); Fri, 29 Apr 2022 12:50:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37306 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1379282AbiD2QuX (ORCPT ); Fri, 29 Apr 2022 12:50:23 -0400 Received: from mail-qt1-x834.google.com (mail-qt1-x834.google.com [IPv6:2607:f8b0:4864:20::834]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A50D2D5E80 for ; Fri, 29 Apr 2022 09:47:04 -0700 (PDT) Received: by mail-qt1-x834.google.com with SMTP id y3so6179101qtn.8 for ; Fri, 29 Apr 2022 09:47:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:subject:message-id:mime-version:content-disposition; bh=OPG/WbHsbgFOvJv9xt9caXn7O/pNdDi/DPsrTup3DFM=; b=brL8y9jop/WYMfEouoEj+LxFNMQnJCRO/RUJObX2EAvBJEMbCUk0C8gJamJTAe6SDD xlYOQeyl7vgKycsN31pjj/IIdSoCfHvvFQLUTo28vs887mn+oD+rKevgBlqxAz3yP4bc CwEIaHFo8oWyzjjkYFsLWKE3wqiTd4KtHgLxcRQf9ghOTpTtg3rhu2jryQyAYvi3pdXQ btGYxnTdNopYDORIBsOnZ63nLMHTmCtTjsrHKJ0C+uY0zWPrgwKI6pvMHUe0TyPTWUWW CgChtrg9YmWmWrRrnFc5F1I1VesPY4Vu0sMpa1C/y+APNxAYhwNXVHDDBW8zGd11HIDh scOQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:subject:message-id:mime-version :content-disposition; bh=OPG/WbHsbgFOvJv9xt9caXn7O/pNdDi/DPsrTup3DFM=; b=KaxeMg/XuVYMOnxcAyjSRkDQbhihM8T+5I1HfD2uUAqXj3fkw+MTjKz8osuG473Enr HWEU5650bhikdyeqImQh6ZvEpVtp09L7CHrFfw5X3+PazsRNKe4TFBzEVXTTTShleycZ ZWiY0EGoNrh7rdZArlUGbN3a/Ajwi87zBRS0WIpdqffmYbMbpOXiTKcLZXc7/gXi2Qyw Q1TpLWdnFqCvKl09V1xjQMcZPBJBkSCODC9tOs0ce1ZDM6SbVAYqbouTdiaaNRRCJWKy qhxueAIdhx4TmH53veN5X/D8i8yjyuqeIsauvh9XtQb2nffIF2flQRRNY62Z1Xa0lUfR +1uw== X-Gm-Message-State: AOAM530j+kKfM1pzpKJP00n56WoXEg/exrKlNYA11T/yEw8GDlJjPUEu AFZZl6vrXoy4fiLlutywnQQBS+gm1VzPbw== X-Google-Smtp-Source: ABdhPJxDqQeFLdpL6vQvdxCjdLX5IN/UtpZKWf0g56XbJk3I0FDmG7NizU9Hk9gqtSyWeJpohvxMLQ== X-Received: by 2002:ac8:5a10:0:b0:2f3:90c5:5f0c with SMTP id n16-20020ac85a10000000b002f390c55f0cmr254369qta.121.1651250823754; Fri, 29 Apr 2022 09:47:03 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id g187-20020a37b6c4000000b0069f840cb643sm1667921qkf.102.2022.04.29.09.47.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 29 Apr 2022 09:47:02 -0700 (PDT) Date: Fri, 29 Apr 2022 12:46:58 -0400 From: Jaehee Park To: outreachy@lists.linux.dev, Julia Denham , Roopa Prabhu , Stefano Brivio , netdev@vger.kernel.org, jhpark1013@gmail.com, Roopa Prabhu , David Ahern Subject: [PATCH net-next v4] selftests: net: vrf_strict_mode_test: add support to select a test to run Message-ID: <20220429164658.GA656707@jaehee-ThinkPad-X1-Extreme> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Add a boilerplate test loop to run all tests in vrf_strict_mode_test.sh. Add a -t flag that allows a selected test to run. Remove the vrf_strict_mode_tests function which is now unused. Signed-off-by: Jaehee Park --- v2 - Add a -t flag that allows a selected test to run. v3 - Add commented delineators to section the code for improved readability. - Move the log_section() call into the functions handling the tests. - Remove unnecessary spaces. v4 - Remove unused function - Edit the patch log to reflect this change. .../selftests/net/vrf_strict_mode_test.sh | 48 +++++++++++++++---- 1 file changed, 39 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/net/vrf_strict_mode_test.sh b/tools/testing/selftests/net/vrf_strict_mode_test.sh index 865d53c1781c..417d214264f3 100755 --- a/tools/testing/selftests/net/vrf_strict_mode_test.sh +++ b/tools/testing/selftests/net/vrf_strict_mode_test.sh @@ -14,6 +14,8 @@ INIT_NETNS_NAME="init" PAUSE_ON_FAIL=${PAUSE_ON_FAIL:=no} +TESTS="init testns mix" + log_test() { local rc=$1 @@ -262,6 +264,8 @@ cleanup() vrf_strict_mode_tests_init() { + log_section "VRF strict_mode test on init network namespace" + vrf_strict_mode_check_support init strict_mode_check_default init @@ -292,6 +296,8 @@ vrf_strict_mode_tests_init() vrf_strict_mode_tests_testns() { + log_section "VRF strict_mode test on testns network namespace" + vrf_strict_mode_check_support testns strict_mode_check_default testns @@ -318,6 +324,8 @@ vrf_strict_mode_tests_testns() vrf_strict_mode_tests_mix() { + log_section "VRF strict_mode test mixing init and testns network namespaces" + read_strict_mode_compare_and_check init 1 read_strict_mode_compare_and_check testns 0 @@ -341,18 +349,30 @@ vrf_strict_mode_tests_mix() read_strict_mode_compare_and_check testns 0 } -vrf_strict_mode_tests() -{ - log_section "VRF strict_mode test on init network namespace" - vrf_strict_mode_tests_init +################################################################################ +# usage - log_section "VRF strict_mode test on testns network namespace" - vrf_strict_mode_tests_testns +usage() +{ + cat < Test(s) to run (default: all) + (options: $TESTS) +EOF } +################################################################################ +# main + +while getopts ":t:h" opt; do + case $opt in + t) TESTS=$OPTARG;; + h) usage; exit 0;; + *) usage; exit 1;; + esac +done + vrf_strict_mode_check_support() { local nsname=$1 @@ -391,7 +411,17 @@ fi cleanup &> /dev/null setup -vrf_strict_mode_tests +for t in $TESTS +do + case $t in + vrf_strict_mode_tests_init|init) vrf_strict_mode_tests_init;; + vrf_strict_mode_tests_testns|testns) vrf_strict_mode_tests_testns;; + vrf_strict_mode_tests_mix|mix) vrf_strict_mode_tests_mix;; + + help) echo "Test names: $TESTS"; exit 0;; + + esac +done cleanup print_log_test_results -- 2.25.1