From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00FC1C433EF for ; Sat, 30 Apr 2022 02:42:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1382088AbiD3Cpc (ORCPT ); Fri, 29 Apr 2022 22:45:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59160 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237621AbiD3Cpb (ORCPT ); Fri, 29 Apr 2022 22:45:31 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FB288C7F5 for ; Fri, 29 Apr 2022 19:42:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 640F3B8354D for ; Sat, 30 Apr 2022 02:42:10 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C6283C385A7; Sat, 30 Apr 2022 02:42:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651286529; bh=GEuLQdxDHLodtyuSsN82uCzuz1jz4IzNQ4a/ZujIl5E=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=c4CCx/SC4a0ZUsEXd6+nowQ2gSlfdrx8jQSBlv628mf2jVg7E+pexIxhB+imR3zh2 kdvLnB7ZHqRJm9P+rQI9YdoXAhKl6NZMLHLQHYUTeQn3s3HTsSHZT6iiOJotjkeRaZ jYSuxz8ap8jgKIBGkpEA2YAJb6xAbv3kuuUmIJOvowrxjIsWfxhMqpAUqxjWeaTDRM LMKNbErRn4JR3uIIMnJWIEuYxS4UF/9SPahTAFuMwB4LMAmeOgRGw879hNegUPdxRX BQpwWmqaF3rAj1nIbIr7z+AOZTW83l3GNGZAbS0bfkJvT2sIDm/ae3o6nxAdJnIpnO Gx5jzVs4z/sCg== Date: Fri, 29 Apr 2022 19:42:07 -0700 From: Jakub Kicinski To: "Nambiar, Amritha" Cc: "Nguyen, Anthony L" , "davem@davemloft.net" , "pabeni@redhat.com" , "edumazet@google.com" , "netdev@vger.kernel.org" , "Mogilappagari, Sudheer" , "Samudrala, Sridhar" , "Sreenivas, Bharathi" , Jamal Hadi Salim Subject: Re: [PATCH net-next 01/11] ice: Add support for classid based queue selection Message-ID: <20220429194207.3f17bf96@kernel.org> In-Reply-To: References: <20220428172430.1004528-1-anthony.l.nguyen@intel.com> <20220428172430.1004528-2-anthony.l.nguyen@intel.com> <20220428160414.28990a0c@kernel.org> <20220429171717.5b0b2a81@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sat, 30 Apr 2022 02:00:05 +0000 Nambiar, Amritha wrote: > IIUC, currently the action skbedit queue_mapping is for transmit queue selection, > and the bound checking is w.r.to dev->real_num_tx_queues. Also, based on my > discussion with Alex (https://www.spinics.net/lists/netdev/msg761581.html), it > looks like this currently applies at the qdisc enqueue stage and not at the > classifier level. They both apply at enqueue stage, AFAIU. Setting classid on ingress does exactly nothing, no? :) Neither is perfect, at least skbedit seems more straightforward. I suspect modern DC operator may have little familiarity with classful qdiscs and what classid is. Plus, again, you're assuming mqprio's interpretation like it's a TC-wide thing. skbedit OTOH is used with a clsact qdisc. Also it would be good if what we did had some applicability to SW. Maybe extend skbedit with a way of calling skb_record_rx_queue()?