From: Marc Kleine-Budde <mkl@pengutronix.de>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, linux-can@vger.kernel.org,
kernel@pengutronix.de,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
Abaci Robot <abaci@linux.alibaba.com>,
Pave Pisa <pisa@cmp.felk.cvut.cz>,
Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH net-next 6/9] can: ctucanfd: ctucan_platform_probe(): remove unnecessary print function dev_err()
Date: Mon, 2 May 2022 09:59:11 +0200 [thread overview]
Message-ID: <20220502075914.1905039-7-mkl@pengutronix.de> (raw)
In-Reply-To: <20220502075914.1905039-1-mkl@pengutronix.de>
From: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
The print function dev_err() is redundant because platform_get_irq()
already prints an error.
Eliminate the follow coccicheck warnings:
| drivers/net/can/ctucanfd/ctucanfd_platform.c:67:2-9:
| line 67 is redundant because platform_get_irq() already prints an error.
Link: https://lore.kernel.org/all/20220421203242.7335-1-jiapeng.chong@linux.alibaba.com
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Acked-by: Pave Pisa <pisa@cmp.felk.cvut.cz>
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/ctucanfd/ctucanfd_platform.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/can/ctucanfd/ctucanfd_platform.c b/drivers/net/can/ctucanfd/ctucanfd_platform.c
index 5e4806068662..89d54c2151e1 100644
--- a/drivers/net/can/ctucanfd/ctucanfd_platform.c
+++ b/drivers/net/can/ctucanfd/ctucanfd_platform.c
@@ -64,7 +64,6 @@ static int ctucan_platform_probe(struct platform_device *pdev)
}
irq = platform_get_irq(pdev, 0);
if (irq < 0) {
- dev_err(dev, "Cannot find interrupt.\n");
ret = irq;
goto err;
}
--
2.35.1
next prev parent reply other threads:[~2022-05-02 7:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 7:59 [PATCH net-next 0/9] pull-request: can-next 2022-05-02 Marc Kleine-Budde
2022-05-02 7:59 ` [PATCH net-next 1/9] dt-bindings: can: renesas,rcar-canfd: Document RZ/G2UL support Marc Kleine-Budde
2022-05-02 11:20 ` patchwork-bot+netdevbpf
2022-05-02 7:59 ` [PATCH net-next 2/9] can: m_can: remove a copy of the NAPI_POLL_WEIGHT define Marc Kleine-Budde
2022-05-02 7:59 ` [PATCH net-next 3/9] docs: networking: device drivers: can: add ctucanfd to index Marc Kleine-Budde
2022-05-02 7:59 ` [PATCH net-next 4/9] docs: networking: device drivers: can: ctucanfd: update author e-mail Marc Kleine-Budde
2022-05-02 7:59 ` [PATCH net-next 5/9] can: ctucanfd: remove unused including <linux/version.h> Marc Kleine-Budde
2022-05-02 7:59 ` Marc Kleine-Budde [this message]
2022-05-02 7:59 ` [PATCH net-next 7/9] can: ctucanfd: remove inline keyword from local static functions Marc Kleine-Budde
2022-05-02 7:59 ` [PATCH net-next 8/9] can: ctucanfd: remove debug statements Marc Kleine-Budde
2022-05-02 7:59 ` [PATCH net-next 9/9] can: ctucanfd: remove PCI module debug parameters Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220502075914.1905039-7-mkl@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=abaci@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pisa@cmp.felk.cvut.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).