netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Niels Dossche <dossche.niels@gmail.com>
Cc: netdev@vger.kernel.org, Sunil Goutham <sgoutham@marvell.com>,
	Linu Cherian <lcherian@marvell.com>,
	Geetha sowjanya <gakula@marvell.com>,
	Jerin Jacob <jerinj@marvell.com>, hariprasad <hkelam@marvell.com>,
	Subbaraya Sundeep <sbhatta@marvell.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Paolo Abeni <pabeni@redhat.com>,
	Harman Kalra <hkalra@marvell.com>,
	Christina Jacob <cjacob@marvell.com>
Subject: Re: [PATCH net] octeontx2-af: debugfs: fix error return of allocations
Date: Mon, 2 May 2022 14:31:01 -0700	[thread overview]
Message-ID: <20220502143101.3aa37dac@kernel.org> (raw)
In-Reply-To: <20220430194656.44357-1-dossche.niels@gmail.com>

On Sat, 30 Apr 2022 21:46:56 +0200 Niels Dossche wrote:
> @@ -407,7 +407,7 @@ static ssize_t rvu_dbg_rsrc_attach_status(struct file *filp,
>  
>  	buf = kzalloc(buf_size, GFP_KERNEL);
>  	if (!buf)
> -		return -ENOSPC;
> +		return -ENOMEM;
>  
>  	/* Get the maximum width of a column */
>  	lf_str_size = get_max_column_width(rvu);

Looks intentional, other allocation failures in this file use ENOMEM.
Still probably worth cleaning up, applied to net-next.

  reply	other threads:[~2022-05-02 21:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-30 19:46 [PATCH net] octeontx2-af: debugfs: fix error return of allocations Niels Dossche
2022-05-02 21:31 ` Jakub Kicinski [this message]
2022-05-02 21:40 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220502143101.3aa37dac@kernel.org \
    --to=kuba@kernel.org \
    --cc=cjacob@marvell.com \
    --cc=davem@davemloft.net \
    --cc=dossche.niels@gmail.com \
    --cc=edumazet@google.com \
    --cc=gakula@marvell.com \
    --cc=hkalra@marvell.com \
    --cc=hkelam@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=lcherian@marvell.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=sbhatta@marvell.com \
    --cc=sgoutham@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).