From: Alex Williamson <alex.williamson@redhat.com>
To: Yishai Hadas <yishaih@nvidia.com>
Cc: <jgg@nvidia.com>, <saeedm@nvidia.com>, <kvm@vger.kernel.org>,
<netdev@vger.kernel.org>, <kuba@kernel.org>, <leonro@nvidia.com>,
<maorg@nvidia.com>, <cohuck@redhat.com>
Subject: Re: [PATCH mlx5-next 0/5] Improve mlx5 live migration driver
Date: Wed, 4 May 2022 14:19:19 -0600 [thread overview]
Message-ID: <20220504141919.3bb4ee76.alex.williamson@redhat.com> (raw)
In-Reply-To: <4295eaec-9b11-8665-d3b4-b986a65d1d47@nvidia.com>
On Wed, 4 May 2022 16:29:37 +0300
Yishai Hadas <yishaih@nvidia.com> wrote:
> On 27/04/2022 12:31, Yishai Hadas wrote:
> > This series improves mlx5 live migration driver in few aspects as of
> > below.
> >
> > Refactor to enable running migration commands in parallel over the PF
> > command interface.
> >
> > To achieve that we exposed from mlx5_core an API to let the VF be
> > notified before that the PF command interface goes down/up. (e.g. PF
> > reload upon health recovery).
> >
> > Once having the above functionality in place mlx5 vfio doesn't need any
> > more to obtain the global PF lock upon using the command interface but
> > can rely on the above mechanism to be in sync with the PF.
> >
> > This can enable parallel VFs migration over the PF command interface
> > from kernel driver point of view.
> >
> > In addition,
> > Moved to use the PF async command mode for the SAVE state command.
> > This enables returning earlier to user space upon issuing successfully
> > the command and improve latency by let things run in parallel.
> >
> > Alex, as this series touches mlx5_core we may need to send this in a
> > pull request format to VFIO to avoid conflicts before acceptance.
> >
> > Yishai
> >
> > Yishai Hadas (5):
> > vfio/mlx5: Reorganize the VF is migratable code
> > net/mlx5: Expose mlx5_sriov_blocking_notifier_register / unregister
> > APIs
> > vfio/mlx5: Manage the VF attach/detach callback from the PF
> > vfio/mlx5: Refactor to enable VFs migration in parallel
> > vfio/mlx5: Run the SAVE state command in an async mode
> >
> > .../net/ethernet/mellanox/mlx5/core/sriov.c | 65 ++++-
> > drivers/vfio/pci/mlx5/cmd.c | 229 +++++++++++++-----
> > drivers/vfio/pci/mlx5/cmd.h | 50 +++-
> > drivers/vfio/pci/mlx5/main.c | 133 +++++-----
> > include/linux/mlx5/driver.h | 12 +
> > 5 files changed, 358 insertions(+), 131 deletions(-)
> >
> Hi Alex,
>
> Did you have the chance to look at the series ? It touches mlx5 code
> (vfio, net), no core changes.
>
> This may go apparently via your tree as a PR from mlx5-next once you'll
> be fine with.
As Jason noted, the net/mlx5 changes seem confined to the 2nd patch,
which has no other dependencies in this series. Is there something
else blocking committing that via the mlx tree and providing a branch
for the remainder to go in through the vfio tree? Thanks,
Alex
next prev parent reply other threads:[~2022-05-04 20:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-27 9:31 [PATCH mlx5-next 0/5] Improve mlx5 live migration driver Yishai Hadas
2022-04-27 9:31 ` [PATCH mlx5-next 1/5] vfio/mlx5: Reorganize the VF is migratable code Yishai Hadas
2022-05-04 20:13 ` Alex Williamson
2022-05-08 12:56 ` Yishai Hadas
2022-04-27 9:31 ` [PATCH mlx5-next 2/5] net/mlx5: Expose mlx5_sriov_blocking_notifier_register / unregister APIs Yishai Hadas
2022-05-04 13:55 ` Jason Gunthorpe
2022-04-27 9:31 ` [PATCH mlx5-next 3/5] vfio/mlx5: Manage the VF attach/detach callback from the PF Yishai Hadas
2022-05-04 20:34 ` Alex Williamson
2022-05-08 13:04 ` Yishai Hadas
2022-04-27 9:31 ` [PATCH mlx5-next 4/5] vfio/mlx5: Refactor to enable VFs migration in parallel Yishai Hadas
2022-04-27 9:31 ` [PATCH mlx5-next 5/5] vfio/mlx5: Run the SAVE state command in an async mode Yishai Hadas
2022-05-04 13:29 ` [PATCH mlx5-next 0/5] Improve mlx5 live migration driver Yishai Hadas
2022-05-04 20:19 ` Alex Williamson [this message]
2022-05-04 21:33 ` Jason Gunthorpe
2022-05-04 22:48 ` Alex Williamson
2022-05-05 5:38 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504141919.3bb4ee76.alex.williamson@redhat.com \
--to=alex.williamson@redhat.com \
--cc=cohuck@redhat.com \
--cc=jgg@nvidia.com \
--cc=kuba@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=leonro@nvidia.com \
--cc=maorg@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).