From: Yuiko Oshino <yuiko.oshino@microchip.com>
To: <woojung.huh@microchip.com>, <yuiko.oshino@microchip.com>,
<davem@davemloft.net>, <netdev@vger.kernel.org>, <andrew@lunn.ch>,
<ravi.hegde@microchip.com>, <UNGLinuxDriver@microchip.com>
Subject: [PATCH v3 net-next 1/2] net: phy: microchip: update LAN88xx phy ID and phy ID mask.
Date: Wed, 4 May 2022 08:28:21 -0700 [thread overview]
Message-ID: <20220504152822.11890-2-yuiko.oshino@microchip.com> (raw)
In-Reply-To: <20220504152822.11890-1-yuiko.oshino@microchip.com>
update LAN88xx phy ID and phy ID mask because the existing code conflicts with the LAN8742 phy.
The current phy IDs on the available hardware.
LAN8742 0x0007C130, 0x0007C131
LAN88xx 0x0007C132
Signed-off-by: Yuiko Oshino <yuiko.oshino@microchip.com>
---
drivers/net/phy/microchip.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/net/phy/microchip.c b/drivers/net/phy/microchip.c
index 9f1f2b6c97d4..ccecee2524ce 100644
--- a/drivers/net/phy/microchip.c
+++ b/drivers/net/phy/microchip.c
@@ -344,8 +344,12 @@ static int lan88xx_config_aneg(struct phy_device *phydev)
static struct phy_driver microchip_phy_driver[] = {
{
- .phy_id = 0x0007c130,
- .phy_id_mask = 0xfffffff0,
+ .phy_id = 0x0007c132,
+ /* This mask (0xfffffff2) is to differentiate from
+ * LAN8742 (phy_id 0x0007c130 and 0x0007c131)
+ * and allows future phy_id revisions.
+ */
+ .phy_id_mask = 0xfffffff2,
.name = "Microchip LAN88xx",
/* PHY_GBIT_FEATURES */
@@ -369,7 +373,7 @@ static struct phy_driver microchip_phy_driver[] = {
module_phy_driver(microchip_phy_driver);
static struct mdio_device_id __maybe_unused microchip_tbl[] = {
- { 0x0007c130, 0xfffffff0 },
+ { 0x0007c132, 0xfffffff2 },
{ }
};
--
2.25.1
next prev parent reply other threads:[~2022-05-04 15:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 15:28 [PATCH v3 net-next 0/2] net: phy: add LAN8742 phy support Yuiko Oshino
2022-05-04 15:28 ` Yuiko Oshino [this message]
2022-05-04 21:41 ` [PATCH v3 net-next 1/2] net: phy: microchip: update LAN88xx phy ID and phy ID mask Andrew Lunn
2022-05-04 15:28 ` [PATCH v3 net-next 2/2] net: phy: smsc: add LAN8742 phy support Yuiko Oshino
2022-05-04 21:45 ` Andrew Lunn
2022-05-05 0:47 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504152822.11890-2-yuiko.oshino@microchip.com \
--to=yuiko.oshino@microchip.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ravi.hegde@microchip.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).