From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F04ECC433F5 for ; Wed, 4 May 2022 17:44:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1355967AbiEDRsX (ORCPT ); Wed, 4 May 2022 13:48:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58798 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1359470AbiEDRoV (ORCPT ); Wed, 4 May 2022 13:44:21 -0400 Received: from mail-qv1-xf34.google.com (mail-qv1-xf34.google.com [IPv6:2607:f8b0:4864:20::f34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2BD2052B02; Wed, 4 May 2022 10:07:32 -0700 (PDT) Received: by mail-qv1-xf34.google.com with SMTP id kk28so1274210qvb.3; Wed, 04 May 2022 10:07:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IgL2IduVNcxBKQc1brpNbRJTmw+R5dGVZ1KkF4Imnfs=; b=Eg5gAEMva3cKrtqR2A0Cc+3z5UUxLVsQA8v8rh2j36ZiCIVUt2H4HorcB4rwOuvWR6 JKNe++YLVfI/Sve1YFOIGZQfOgj6AfpwPRB3m/gb/hpvooo0XnPg0HpJYkGOH9nFB0/Q jTK+a8wIo7oIvH3qgH5+ZRDz0YB9ixQ/yKzoe3Ez0ADPXowkRCfMr+HrgabOymRJoOb/ 3LaM0ZlStKwt1NWQQWzHvaMoDJ0ayZ9I1kITpzOHM6iNWLBon1t3UAb6iJMoXE84vHGy NsinH4cIOjFQgXdOI4hiZwDbidIff8YK35NKG3wSwTuTejjAgkljnlNx93NbwOEOFML8 NQDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IgL2IduVNcxBKQc1brpNbRJTmw+R5dGVZ1KkF4Imnfs=; b=xnxKbgmfPoZqd2gr5xmejmfnLe/w+ox889nHfXG0NU/saHQbWZ2GerzWvrLgne2dKD MZ9cmL2l4kaI+5QriaFdODNI2UQIc7yHmPDkf9MRcRXbLBpvL+vtSECueIw5Qk9EYH0z G98SP/qcBv9uuF9Maur70gxPipkyYSiMYVPUK5wmuJq6CUKlYlFO+MM6Pe1LddfLm/bV EBNsbDUDt2f7mrwJ+XLa+tYYgDg2zbSfbAbsdWjX8GYR3AnLK510dHneaaTGDISg59uA 8VWgAlK77uWqMBStcrNHhg0xr7L1Rlg+LjsPX/TQA51Te2ut6aUTEwT29GQKMrT9+iNw l1Ag== X-Gm-Message-State: AOAM530GF1E7/ZkKv2fBh4TUyrsxdlzPentpIN3cLGMJ13fdVfXodWOE hMio2Gh5U/NZNsYaqj7XHqveV64MLj9UIQ== X-Google-Smtp-Source: ABdhPJymonwwKJEu+zKIwUyz7H7uJGSZslAlFiLL0za6AjT3ELvv5KYH3MFj0YwaRMr8wXpaUes4gw== X-Received: by 2002:a0c:ec41:0:b0:456:51c6:1800 with SMTP id n1-20020a0cec41000000b0045651c61800mr18384061qvq.44.1651684051063; Wed, 04 May 2022 10:07:31 -0700 (PDT) Received: from jaehee-ThinkPad-X1-Extreme ([4.34.18.218]) by smtp.gmail.com with ESMTPSA id h3-20020ac85683000000b002f39b99f692sm7647171qta.44.2022.05.04.10.07.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 04 May 2022 10:07:30 -0700 (PDT) Date: Wed, 4 May 2022 13:07:26 -0400 From: Jaehee Park To: Kalle Valo Cc: Dan Carpenter , Stefano Brivio , =?iso-8859-1?B?Suly9G1l?= Pouiller , "David S. Miller" , Jakub Kicinski , Paolo Abeni , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Outreachy Linux Kernel Subject: Re: [PATCH] wfx: use container_of() to get vif Message-ID: <20220504170726.GA970146@jaehee-ThinkPad-X1-Extreme> References: <20220418035110.GA937332@jaehee-ThinkPad-X1-Extreme> <87y200nf0a.fsf@kernel.org> <20220504093347.GB4009@kadam> <20220504135059.7132b2b6@elisabeth> <20220504132551.GD4009@kadam> <87o80d9tay.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87o80d9tay.fsf@kernel.org> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, May 04, 2022 at 07:05:57PM +0300, Kalle Valo wrote: > Dan Carpenter writes: > > > On Wed, May 04, 2022 at 01:50:59PM +0200, Stefano Brivio wrote: > >> And that it's *obvious* that container_of() would trigger warnings > >> otherwise. Well, obvious just for me, it seems. > > > > :P > > > > Apparently it wasn't obvious to Kalle and me. My guess is that you saw > > the build error. Either that or Kalle and I are geezers who haven't > > looked at container_of() since before the BUILD_BUG_ON() was added five > > years ago. > > Exactly, I also had to duplicate the error myself before I was able to > understand the issue. So I'm officially a geezer now :D > Hi Dan and Kalle, thanks for your messages! Understood -- I'll copy the error for reference next time. Sorry you had to recreate the build error yourself! > -- > https://patchwork.kernel.org/project/linux-wireless/list/ > > https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches