[PATCH net-next] net: Make msg_zerocopy_alloc static

[PATCH net-next] net: Make msg_zerocopy_alloc static

[David Ahern]

msg_zerocopy_alloc is only used by msg_zerocopy_realloc; remove the
export and make static in skbuff.c

Signed-off-by: David Ahern <dsahern@kernel.org>
---
 include/linux/skbuff.h | 1 -
 net/core/skbuff.c      | 3 +--
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/include/linux/skbuff.h b/include/linux/skbuff.h
index 3270cb72e4d8..5c2599e3fe7d 100644
--- a/include/linux/skbuff.h
+++ b/include/linux/skbuff.h
@@ -1665,7 +1665,6 @@ static inline void skb_set_end_offset(struct sk_buff *skb, unsigned int offset)
 }
 #endif
 
-struct ubuf_info *msg_zerocopy_alloc(struct sock *sk, size_t size);
 struct ubuf_info *msg_zerocopy_realloc(struct sock *sk, size_t size,
 				       struct ubuf_info *uarg);
 
diff --git a/net/core/skbuff.c b/net/core/skbuff.c
index 475183f37891..15f7b6f99a8f 100644
--- a/net/core/skbuff.c
+++ b/net/core/skbuff.c
@@ -1165,7 +1165,7 @@ void mm_unaccount_pinned_pages(struct mmpin *mmp)
 }
 EXPORT_SYMBOL_GPL(mm_unaccount_pinned_pages);
 
-struct ubuf_info *msg_zerocopy_alloc(struct sock *sk, size_t size)
+static struct ubuf_info *msg_zerocopy_alloc(struct sock *sk, size_t size)
 {
 	struct ubuf_info *uarg;
 	struct sk_buff *skb;
@@ -1196,7 +1196,6 @@ struct ubuf_info *msg_zerocopy_alloc(struct sock *sk, size_t size)
 
 	return uarg;
 }
-EXPORT_SYMBOL_GPL(msg_zerocopy_alloc);
 
 static inline struct sk_buff *skb_from_uarg(struct ubuf_info *uarg)
 {
-- 
2.25.1

Re: [PATCH net-next] net: Make msg_zerocopy_alloc static

[Jonathan Lemon]

On Wed, May 04, 2022 at 10:09:47AM -0700, David Ahern wrote:
> msg_zerocopy_alloc is only used by msg_zerocopy_realloc; remove the
> export and make static in skbuff.c
> 
> Signed-off-by: David Ahern <dsahern@kernel.org>

Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>

Re: [PATCH net-next] net: Make msg_zerocopy_alloc static

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <kuba@kernel.org>:

On Wed,  4 May 2022 10:09:47 -0700 you wrote:
> msg_zerocopy_alloc is only used by msg_zerocopy_realloc; remove the
> export and make static in skbuff.c
> 
> Signed-off-by: David Ahern <dsahern@kernel.org>
> ---
>  include/linux/skbuff.h | 1 -
>  net/core/skbuff.c      | 3 +--
>  2 files changed, 1 insertion(+), 3 deletions(-)

Here is the summary with links:
  - [net-next] net: Make msg_zerocopy_alloc static
    https://git.kernel.org/netdev/net-next/c/c67b627e99af

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html