From: Jakub Kicinski <kuba@kernel.org>
To: Maximilian Heyne <mheyne@amazon.de>
Cc: Jesse Brandeburg <jesse.brandeburg@intel.com>,
Tony Nguyen <anthony.l.nguyen@intel.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH net-next v2] drivers, ixgbe: show VF statistics
Date: Wed, 4 May 2022 20:16:32 -0700 [thread overview]
Message-ID: <20220504201632.2a41a3b9@kernel.org> (raw)
In-Reply-To: <20220503150017.16148-1-mheyne@amazon.de>
On Tue, 3 May 2022 15:00:17 +0000 Maximilian Heyne wrote:
> + for (i = 0; i < adapter->num_vfs; i++) {
> + ethtool_sprintf(&p, "VF %u Rx Packets", i);
> + ethtool_sprintf(&p, "VF %u Rx Bytes", i);
> + ethtool_sprintf(&p, "VF %u Tx Packets", i);
> + ethtool_sprintf(&p, "VF %u Tx Bytes", i);
> + ethtool_sprintf(&p, "VF %u MC Packets", i);
> + }
Please drop the ethtool stats. We've been trying to avoid duplicating
the same stats in ethtool and iproute2 for a while now.
next prev parent reply other threads:[~2022-05-05 3:16 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 15:00 [PATCH net-next v2] drivers, ixgbe: show VF statistics Maximilian Heyne
2022-05-05 3:16 ` Jakub Kicinski [this message]
2022-05-06 6:44 ` Maximilian Heyne
2022-05-06 16:13 ` Jakub Kicinski
2022-05-06 16:20 ` Tony Nguyen
2022-05-09 7:39 ` Maximilian Heyne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504201632.2a41a3b9@kernel.org \
--to=kuba@kernel.org \
--cc=anthony.l.nguyen@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jesse.brandeburg@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mheyne@amazon.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).