From: Jakub Kicinski <kuba@kernel.org>
To: Martin Habets <habetsm.xilinx@gmail.com>
Cc: edumazet@google.com, pabeni@redhat.com, davem@davemloft.net,
netdev@vger.kernel.org, ecree.xilinx@gmail.com
Subject: Re: [PATCH net-next v3 00/13]: Move Siena into a separate subdirectory
Date: Wed, 4 May 2022 20:45:31 -0700 [thread overview]
Message-ID: <20220504204531.5294ed21@kernel.org> (raw)
In-Reply-To: <165165052672.13116.6437319692346674708.stgit@palantir17.mph.net>
On Wed, 04 May 2022 08:49:41 +0100 Martin Habets wrote:
> The Siena NICs (SFN5000 and SFN6000 series) went EOL in November 2021.
> Most of these adapters have been remove from our test labs, and testing
> has been reduced to a minimum.
>
> This patch series creates a separate kernel module for the Siena architecture,
> analogous to what was done for Falcon some years ago.
> This reduces our maintenance for the sfc.ko module, and allows us to
> enhance the EF10 and EF100 drivers without the risk of breaking Siena NICs.
>
> After this series further enhancements are needed to differentiate the
> new kernel module from sfc.ko, and the Siena code can be removed from sfc.ko.
> Thes will be posted as a small follow-up series.
> The Siena module is not built by default, but can be enabled
> using Kconfig option SFC_SIENA. This will create module sfc-siena.ko.
>
> Patches
>
> Patch 1 disables the Siena code in the sfc.ko module.
> Patches 2-6 establish the code base for the Siena driver.
> Patches 7-12 ensure the allyesconfig build succeeds.
> Patch 13 adds the basic Siena module.
>
> I do not expect patch 2 through 5 to be reviewed, they are FYI only.
> No checkpatch issues were resolved as part of these, but they
> were fixed in the subsequent patches.
Still funky:
$ git pw series apply 638179
Applying: sfc: Disable Siena support
Using index info to reconstruct a base tree...
M drivers/net/ethernet/sfc/Kconfig
M drivers/net/ethernet/sfc/Makefile
M drivers/net/ethernet/sfc/efx.c
M drivers/net/ethernet/sfc/nic.h
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: sfc: Move Siena specific files
Applying: sfc: Copy shared files needed for Siena (part 1)
Applying: sfc: Copy shared files needed for Siena (part 2)
Applying: sfc: Copy a subset of mcdi_pcol.h to siena
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: sfc/siena: Remove build references to missing functionality
Applying: sfc/siena: Rename functions in efx headers to avoid conflicts with sfc
Applying: sfc/siena: Rename RX/TX functions to avoid conflicts with sfc
Applying: sfc/siena: Rename peripheral functions to avoid conflicts with sfc
Applying: sfc/siena: Rename functions in mcdi headers to avoid conflicts with sfc
Applying: sfc/siena: Rename functions in nic_common.h to avoid conflicts with sfc
Applying: sfc/siena: Inline functions in sriov.h to avoid conflicts with sfc
Applying: sfc: Add a basic Siena module
next prev parent reply other threads:[~2022-05-05 3:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 7:49 [PATCH net-next v3 00/13]: Move Siena into a separate subdirectory Martin Habets
2022-05-04 7:49 ` [PATCH net-next v3 01/13] sfc: Disable Siena support Martin Habets
2022-05-04 7:50 ` [PATCH net-next v3 02/13] sfc: Move Siena specific files Martin Habets
2022-05-04 7:50 ` [PATCH net-next v3 03/13] sfc: Copy shared files needed for Siena (part 1) Martin Habets
2022-05-04 7:50 ` [PATCH net-next v3 04/13] sfc: Copy shared files needed for Siena (part 2) Martin Habets
2022-05-04 7:50 ` [PATCH net-next v3 05/13] sfc: Copy a subset of mcdi_pcol.h to siena Martin Habets
2022-05-04 7:50 ` [PATCH net-next v3 06/13] sfc/siena: Remove build references to missing functionality Martin Habets
2022-05-04 7:51 ` [PATCH net-next v3 07/13] sfc/siena: Rename functions in efx headers to avoid conflicts with sfc Martin Habets
2022-05-04 7:51 ` [PATCH net-next v3 08/13] sfc/siena: Rename RX/TX functions " Martin Habets
2022-05-04 7:51 ` [PATCH net-next v3 09/13] sfc/siena: Rename peripheral " Martin Habets
2022-05-04 7:51 ` [PATCH net-next v3 10/13] sfc/siena: Rename functions in mcdi headers " Martin Habets
2022-05-04 7:51 ` [PATCH net-next v3 11/13] sfc/siena: Rename functions in nic_common.h " Martin Habets
2022-05-04 7:52 ` [PATCH net-next v3 12/13] sfc/siena: Inline functions in sriov.h " Martin Habets
2022-05-04 7:52 ` [PATCH net-next v3 13/13] sfc: Add a basic Siena module Martin Habets
2022-05-04 10:10 ` [PATCH net-next v3 00/13]: Move Siena into a separate subdirectory patchwork-bot+netdevbpf
2022-05-04 10:20 ` patchwork-bot+netdevbpf
2022-05-05 3:45 ` Jakub Kicinski [this message]
2022-05-05 13:00 ` Martin Habets
2022-05-05 16:28 ` Jakub Kicinski
2022-05-09 8:13 ` Martin Habets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220504204531.5294ed21@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).