From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <tariqt@nvidia.com>
Cc: "David S. Miller" <davem@davemloft.net>, <netdev@vger.kernel.org>,
Gal Pressman <gal@nvidia.com>
Subject: Re: [PATCH net] net: Fix features skip in for_each_netdev_feature()
Date: Thu, 5 May 2022 18:30:46 -0700 [thread overview]
Message-ID: <20220505183046.19952bf2@kernel.org> (raw)
In-Reply-To: <20220504080914.1918-1-tariqt@nvidia.com>
On Wed, 4 May 2022 11:09:14 +0300 Tariq Toukan wrote:
> The find_next_netdev_feature() macro gets the "remaining length",
> not bit index.
> Passing "bit - 1" for the following iteration is wrong as it skips
> the adjacent bit. Pass "bit" instead.
>
> Fixes: 3b89ea9c5902 ("net: Fix for_each_netdev_feature on Big endian")
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
> Reviewed-by: Gal Pressman <gal@nvidia.com>
> ---
> include/linux/netdev_features.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> Hi,
> Please queue to -stable >= v5.0.
You can add the normal Cc: stable tags in networking these days,
the rules were updated.
But I'll forgo doing that here since your >= 5.0 is incorrect, looks
like the bad commit got backported to earlier stable branches.
Greg will probably do the right thing based on the Fixes tag, anyway.
next prev parent reply other threads:[~2022-05-06 1:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-04 8:09 [PATCH net] net: Fix features skip in for_each_netdev_feature() Tariq Toukan
2022-05-06 1:30 ` Jakub Kicinski [this message]
2022-05-06 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220505183046.19952bf2@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=gal@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).