From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67CEFC433F5 for ; Sat, 7 May 2022 03:57:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237640AbiEGEBk (ORCPT ); Sat, 7 May 2022 00:01:40 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33620 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230269AbiEGEBj (ORCPT ); Sat, 7 May 2022 00:01:39 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5498758E49 for ; Fri, 6 May 2022 20:57:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id AC3F4B8399F for ; Sat, 7 May 2022 03:57:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A24E9C385A5; Sat, 7 May 2022 03:57:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651895871; bh=yBcYF2B4vAuY+lPmaAvwfuJUvcJf9C4J1Dir3tjmuFc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hn0ZETlw8cuV63sF20c+23YmgzG6bjtFDt6w/FDIt/DgwpDQnBde8PxsPWkj0c1NH 3ncjC5uxqw3Dck/Hq3+hTrkvn5DJAInFkPoaRRG4wL1qSTeY2zfMr7x07KLZKoK4zg mziQSsJ/FH33Iy7hAv48hMRONF5jKDrf2+53xitv6UKc9oZv4NnlIRPoWfDi5YiK6W TAPy9Z6eqy61ZFN/5ozCPipkI/aIAqISybymu614ecO6GnNv/ATRTcnpJM0B1PLfQ3 ylbyQfp71v9hRx1QI3Go0B8l7IAObpLk30LhEqO4igROAVfFL6/3MXb0FkCXWRC7dN HEfBEA5RUphaQ== Date: Fri, 6 May 2022 20:57:49 -0700 From: Jakub Kicinski To: Jonathan Lemon Cc: andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk, f.fainelli@gmail.com, bcm-kernel-feedback-list@broadcom.com, netdev@vger.kernel.org, kernel-team@fb.com, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, lasse@timebeat.app, clk@fb.com Subject: Re: [PATCH net-next v4 1/2] net: phy: broadcom: Add PTP support for some Broadcom PHYs. Message-ID: <20220506205749.2b89ee57@kernel.org> In-Reply-To: <20220506224210.1425817-2-jonathan.lemon@gmail.com> References: <20220506224210.1425817-1-jonathan.lemon@gmail.com> <20220506224210.1425817-2-jonathan.lemon@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 6 May 2022 15:42:09 -0700 Jonathan Lemon wrote: > +struct bcm_ptp_private *bcm_ptp_probe(struct phy_device *phydev) The prototype for probe and init needs to get added in patch 1: drivers/net/phy/bcm-phy-ptp.c:803:6: warning: no previous prototype for function 'bcm_ptp_config_init' [-Wmissing-prototypes] void bcm_ptp_config_init(struct phy_device *phydev) ^ drivers/net/phy/bcm-phy-ptp.c:839:25: warning: no previous prototype for function 'bcm_ptp_probe' [-Wmissing-prototypes] struct bcm_ptp_private *bcm_ptp_probe(struct phy_device *phydev) ^