From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28F78C433EF for ; Mon, 9 May 2022 06:15:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230106AbiEIGT3 (ORCPT ); Mon, 9 May 2022 02:19:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45956 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235607AbiEIGFT (ORCPT ); Mon, 9 May 2022 02:05:19 -0400 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14674163F69; Sun, 8 May 2022 23:01:26 -0700 (PDT) Received: by verein.lst.de (Postfix, from userid 2407) id 7F31468D06; Mon, 9 May 2022 08:01:06 +0200 (CEST) Date: Mon, 9 May 2022 08:01:04 +0200 From: Christoph Hellwig To: Jiri Olsa Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Masami Hiramatsu , Christoph Hellwig , netdev@vger.kernel.org, bpf@vger.kernel.org, lkml , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Steven Rostedt Subject: Re: [PATCHv5 bpf-next 1/5] kallsyms: Fully export kallsyms_on_each_symbol function Message-ID: <20220509060104.GB16939@lst.de> References: <20220507125711.2022238-1-jolsa@kernel.org> <20220507125711.2022238-2-jolsa@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20220507125711.2022238-2-jolsa@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org I'm not sure how I'm supposed to review just a patch 1 out of 5 without the rest. What I can ѕay without the rest is that the subject line is wrong as nothing is exported, and that you are adding an overly long line.