From: Jakub Kicinski <kuba@kernel.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: David Miller <davem@davemloft.net>,
Networking <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Jonathan Corbet <corbet@lwn.net>,
Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
"open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
Doug Brown <doug@schmorgal.com>
Subject: Re: [PATCH net-next] net: appletalk: remove Apple/Farallon LocalTalk PC support
Date: Mon, 9 May 2022 10:32:16 -0700 [thread overview]
Message-ID: <20220509103216.180be080@kernel.org> (raw)
In-Reply-To: <CAK8P3a0FVM8g0LG3_mHJ1xX3Bs9cxae8ez7b9qvGOD+aJdc8Dw@mail.gmail.com>
On Mon, 9 May 2022 19:14:42 +0200 Arnd Bergmann wrote:
> On Mon, May 9, 2022 at 5:01 PM Jakub Kicinski <kuba@kernel.org> wrote:
> >
> > Looks like all the changes to this driver had been tree-wide
> > refactoring since git era begun. The driver is using virt_to_bus()
> > we should make it use more modern DMA APIs but since it's unlikely
> > to be getting any use these days delete it instead. We can always
> > revert to bring it back.
> >
> > Signed-off-by: Jakub Kicinski <kuba@kernel.org>
>
> Removing this driver sounds good to me, your description makes sense
> and it gets us closer to completely removing virt_to_bus() in the future.
>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
>
> I think however, if we remove this driver, we need to discuss removing the
> last remaining localtalk driver (CONFIG_COPS) and possibly the localtalk
> bits in net/appletalk along with it.
>
> Doug Brown suggested removing COPS last year for entirely different
> reasons[1] but never got a reply. I suppose that is a sign that nobody
> cared about the driver enough, but we should remove it. He also
> mentioned working on a new localtalk driver, though I don't think he
> posted that one yet.
>
> Arnd
>
> [1] https://lore.kernel.org/netdev/6c62d7d5-5171-98a3-5287-ecb1df20f574@schmorgal.com/
Very interesting, thanks!
Removing COPS and appletalk makes perfect sense to me (minus what Doug
has plans to use, obviously).
I'm taking notes for "next steps" while trying to strategically cast
a narrow net, hitting VIRT_TO_BUS only now.
next prev parent reply other threads:[~2022-05-09 17:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 15:01 [PATCH net-next] net: appletalk: remove Apple/Farallon LocalTalk PC support Jakub Kicinski
2022-05-09 17:14 ` Arnd Bergmann
2022-05-09 17:32 ` Jakub Kicinski [this message]
2022-05-10 2:34 ` Doug Brown
2022-05-10 6:48 ` Arnd Bergmann
2022-05-11 0:20 ` Doug Brown
2022-05-11 8:23 ` Arnd Bergmann
2022-05-12 18:11 ` James Carlson
2022-05-12 19:21 ` Arnd Bergmann
2022-05-12 19:28 ` Doug Brown
2022-05-11 12:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509103216.180be080@kernel.org \
--to=kuba@kernel.org \
--cc=arnd@arndb.de \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=doug@schmorgal.com \
--cc=edumazet@google.com \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=linux-doc@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).