Re: [RFC v8 net-next 04/16] net: mdio: mscc-miim: add ability to be used in a non-mmio configuration

Andy Shevchenko
2022-05-08T21:14:53Z

On Sun, May 8, 2022 at 8:53 PM Colin Foster
<colin.foster@in-advantage.com> wrote:
>
> There are a few Ocelot chips that contain the logic for this bus, but are
> controlled externally. Specifically the VSC7511, 7512, 7513, and 7514. In
> the externally controlled configurations these registers are not
> memory-mapped.
>
> Add support for these non-memory-mapped configurations.

...

> + res = platform_get_resource(pdev, IORESOURCE_REG, 0);
> + if (!res) {
> + dev_err(dev, "Unable to get MIIM resource\n");
> + return -ENODEV;

return dev_err_probe(...); ?

> + }

...

> + if (IS_ERR(phy_regmap)) {
> + dev_err(dev, "Unable to create phy register regmap\n");
> + return PTR_ERR(phy_regmap);

Ditto.

> }

--
With Best Regards,
Andy Shevchenko