From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00515C433F5 for ; Tue, 10 May 2022 01:07:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234122AbiEJBLM (ORCPT ); Mon, 9 May 2022 21:11:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234118AbiEJBLL (ORCPT ); Mon, 9 May 2022 21:11:11 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 275A67CB3B for ; Mon, 9 May 2022 18:07:16 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id C44C8B81A2A for ; Tue, 10 May 2022 01:07:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44B11C385C5; Tue, 10 May 2022 01:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652144833; bh=iflYNXVWpMlsUw0T7Rz5hqdt7Xo93lnSJ9zgydfJVSk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Wwn8oWMFkzKpjFEsnnVCLtrG8KedsbDu2/xGZ1naEiff0VuBkojhDatb8YIKJI5xH CYktdsL71bt/UZ+aIwL6C8K6vv7LiKKpjNyxPuVMNPslfCi/OSkY4nH5kltfyyqV2O 9z4tM9sgqP6v8XHtBkoRWA+eza5DQ9lxYtNa74ALrK7nrWoyOPRFwSi8avEnOT3Q9T A1gNyPBzinz4byyTzXTab/VRJbPETclzXQSP7Hu1qr4oi/CUYHDYVfdXzF7tcqLHMB lsdpXtCOPY3aErLng/WJdbqIn8jeIYNxCIoGeWOWvs4okfrFgcmbzgne06TK8wx+Zg IDdpE99gw5PSg== Date: Mon, 9 May 2022 18:07:12 -0700 From: Jakub Kicinski To: Xin Long Cc: network dev , davem@davemloft.net, Edward Cree Subject: Re: [PATCH net] Documentation: add description for net.core.gro_normal_batch Message-ID: <20220509180712.22f4a3a7@kernel.org> In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 6 May 2022 14:20:13 -0400 Xin Long wrote: > Describe it in admin-guide/sysctl/net.rst like other Network core options. > Users need to know gro_normal_batch for performance tuning. > > Fixes: 323ebb61e32b ("net: use listified RX for handling GRO_NORMAL skbs") > Reported-by: Prijesh Does Prijesh have a last name? :) > Signed-off-by: Xin Long > --- > Documentation/admin-guide/sysctl/net.rst | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/admin-guide/sysctl/net.rst b/Documentation/admin-guide/sysctl/net.rst > index f86b5e1623c6..d8a8506f31ad 100644 > --- a/Documentation/admin-guide/sysctl/net.rst > +++ b/Documentation/admin-guide/sysctl/net.rst > @@ -374,6 +374,16 @@ option is set to SOCK_TXREHASH_DEFAULT (i. e. not overridden by setsockopt). > If set to 1 (default), hash rethink is performed on listening socket. > If set to 0, hash rethink is not performed. > > +gro_normal_batch > +---------------- > + > +Maximum number of GRO_NORMAL skbs to batch up for list-RX. When GRO decides > +not to coalesce a packet, instead of passing it to the stack immediately, > +place it on a list. That makes it sounds like only packets which were not coalesced go on the list. IIUC everything goes on that list before traveling up the stack, no? > +Pass this list to the stack at flush time or whenever This sentences is in second person, and the previous one was in third person. > +the number of skbs in this list exceeds gro_normal_batch. s/skbs/segments/ > +Default : 8 > + > 2. /proc/sys/net/unix - Parameters for Unix domain sockets > ---------------------------------------------------------- >