From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: kernel test robot <lkp@intel.com>,
Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
kbuild-all@lists.01.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 3/4] net: warn if transport header was not set
Date: Mon, 9 May 2022 19:23:19 -0700 [thread overview]
Message-ID: <20220509192319.1fc6729a@kernel.org> (raw)
In-Reply-To: <CANn89iK6ydh4JctuYN3DCpMxp+5NhbSVV2=CA50MLOJYJH6HFQ@mail.gmail.com>
On Mon, 9 May 2022 19:11:15 -0700 Eric Dumazet wrote:
> On Mon, May 9, 2022 at 6:30 PM Jakub Kicinski <kuba@kernel.org> wrote:
> > Yeah the order of inclusion is skbuff -> netdevice, as you probably
> > figured out by yourself. We may want to pull back the code move for
> > the print helpers. Unless you have cycles to untangle that :S
>
> I added at the beginning of the new file :
>
> #include <linux/bug.h>
> struct net_device;
>
> Hopefully this is enough.
Maybe toss in linux/kern_levels.h for a good measure?
netdev_WARN() uses netdev_name() but it's a macro, so the users of that
will need to include netdevice.h, or we could leave netdev_WARN() in
netdevice.h. Doesn't matter in practice.
next prev parent reply other threads:[~2022-05-10 2:23 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 19:08 [PATCH net-next 0/4] net: CONFIG_DEBUG_NET and friends Eric Dumazet
2022-05-09 19:08 ` [PATCH net-next 1/4] net: add include/net/net_debug.h Eric Dumazet
2022-05-09 19:08 ` [PATCH net-next 2/4] net: add CONFIG_DEBUG_NET Eric Dumazet
2022-05-09 19:08 ` [PATCH net-next 3/4] net: warn if transport header was not set Eric Dumazet
2022-05-09 23:31 ` kernel test robot
2022-05-09 23:52 ` Eric Dumazet
2022-05-10 1:30 ` Jakub Kicinski
2022-05-10 2:11 ` Eric Dumazet
2022-05-10 2:23 ` Jakub Kicinski [this message]
2022-05-09 23:31 ` kernel test robot
2022-05-09 23:51 ` kernel test robot
2022-05-09 19:08 ` [PATCH net-next 4/4] net: remove two BUG() from skb_checksum_help() Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220509192319.1fc6729a@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=lkp@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).