From: "Michael S. Tsirkin" <mst@redhat.com>
To: Tang Bin <tangbin@cmss.chinamobile.com>
Cc: jasowang@redhat.com, davem@davemloft.net, kuba@kernel.org,
pabeni@redhat.com, virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash()
Date: Tue, 10 May 2022 01:22:34 -0400 [thread overview]
Message-ID: <20220510012221-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20220509131432.16568-1-tangbin@cmss.chinamobile.com>
On Mon, May 09, 2022 at 09:14:32PM +0800, Tang Bin wrote:
> In this function, "VIRTIO_NET_HASH_REPORT_NONE" is included
> in "default", so it canbe removed.
>
> Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com>
What's the point of this?
> ---
> drivers/net/virtio_net.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/virtio_net.c b/drivers/net/virtio_net.c
> index 87838cbe3..b3e5d8637 100644
> --- a/drivers/net/virtio_net.c
> +++ b/drivers/net/virtio_net.c
> @@ -1172,7 +1172,6 @@ static void virtio_skb_set_hash(const struct virtio_net_hdr_v1_hash *hdr_hash,
> case VIRTIO_NET_HASH_REPORT_IPv6_EX:
> rss_hash_type = PKT_HASH_TYPE_L3;
> break;
> - case VIRTIO_NET_HASH_REPORT_NONE:
> default:
> rss_hash_type = PKT_HASH_TYPE_NONE;
> }
> --
> 2.20.1.windows.1
>
>
prev parent reply other threads:[~2022-05-10 5:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 13:14 [PATCH] virtio_net: Remove unused case in virtio_skb_set_hash() Tang Bin
2022-05-10 2:05 ` Jason Wang
2022-05-10 5:22 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510012221-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tangbin@cmss.chinamobile.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).