From: kernel test robot <lkp@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: kbuild-all@lists.01.org, netdev <netdev@vger.kernel.org>,
Alexander Duyck <alexanderduyck@fb.com>,
Coco Li <lixiaoyan@google.com>,
Eric Dumazet <edumazet@google.com>
Subject: Re: [PATCH v5 net-next 02/13] net: allow gso_max_size to exceed 65536
Date: Tue, 10 May 2022 09:35:55 +0800 [thread overview]
Message-ID: <202205100923.RHeXqtNd-lkp@intel.com> (raw)
In-Reply-To: <20220509222149.1763877-3-eric.dumazet@gmail.com>
Hi Eric,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url: https://github.com/intel-lab-lkp/linux/commits/Eric-Dumazet/tcp-BIG-TCP-implementation/20220510-062530
base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9c095bd0d4c451d31d0fd1131cc09d3b60de815d
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220510/202205100923.RHeXqtNd-lkp@intel.com/config)
compiler: gcc-11 (Debian 11.2.0-20) 11.2.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/8f9b47ee99f57d1747010d002315092bfa17ed50
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Eric-Dumazet/tcp-BIG-TCP-implementation/20220510-062530
git checkout 8f9b47ee99f57d1747010d002315092bfa17ed50
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from include/net/inet_sock.h:22,
from include/net/ip.h:29,
from include/linux/errqueue.h:6,
from net/core/sock.c:91:
net/core/sock.c: In function 'sk_setup_caps':
>> include/net/sock.h:389:37: error: 'struct sock_common' has no member named 'skc_v6_rcv_saddr'; did you mean 'skc_rcv_saddr'?
389 | #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
| ^~~~~~~~~~~~~~~~
net/core/sock.c:2317:72: note: in expansion of macro 'sk_v6_rcv_saddr'
2317 | !sk_is_tcp(sk) || ipv6_addr_v4mapped(&sk->sk_v6_rcv_saddr)))
| ^~~~~~~~~~~~~~~
vim +389 include/net/sock.h
4dc6dc7162c08b Eric Dumazet 2009-07-15 368
68835aba4d9b74 Eric Dumazet 2010-11-30 369 #define sk_dontcopy_begin __sk_common.skc_dontcopy_begin
68835aba4d9b74 Eric Dumazet 2010-11-30 370 #define sk_dontcopy_end __sk_common.skc_dontcopy_end
4dc6dc7162c08b Eric Dumazet 2009-07-15 371 #define sk_hash __sk_common.skc_hash
5080546682bae3 Eric Dumazet 2013-10-02 372 #define sk_portpair __sk_common.skc_portpair
05dbc7b59481ca Eric Dumazet 2013-10-03 373 #define sk_num __sk_common.skc_num
05dbc7b59481ca Eric Dumazet 2013-10-03 374 #define sk_dport __sk_common.skc_dport
5080546682bae3 Eric Dumazet 2013-10-02 375 #define sk_addrpair __sk_common.skc_addrpair
5080546682bae3 Eric Dumazet 2013-10-02 376 #define sk_daddr __sk_common.skc_daddr
5080546682bae3 Eric Dumazet 2013-10-02 377 #define sk_rcv_saddr __sk_common.skc_rcv_saddr
^1da177e4c3f41 Linus Torvalds 2005-04-16 378 #define sk_family __sk_common.skc_family
^1da177e4c3f41 Linus Torvalds 2005-04-16 379 #define sk_state __sk_common.skc_state
^1da177e4c3f41 Linus Torvalds 2005-04-16 380 #define sk_reuse __sk_common.skc_reuse
055dc21a1d1d21 Tom Herbert 2013-01-22 381 #define sk_reuseport __sk_common.skc_reuseport
9fe516ba3fb29b Eric Dumazet 2014-06-27 382 #define sk_ipv6only __sk_common.skc_ipv6only
26abe14379f8e2 Eric W. Biederman 2015-05-08 383 #define sk_net_refcnt __sk_common.skc_net_refcnt
^1da177e4c3f41 Linus Torvalds 2005-04-16 384 #define sk_bound_dev_if __sk_common.skc_bound_dev_if
^1da177e4c3f41 Linus Torvalds 2005-04-16 385 #define sk_bind_node __sk_common.skc_bind_node
8feaf0c0a5488b Arnaldo Carvalho de Melo 2005-08-09 386 #define sk_prot __sk_common.skc_prot
07feaebfcc10cd Eric W. Biederman 2007-09-12 387 #define sk_net __sk_common.skc_net
efe4208f47f907 Eric Dumazet 2013-10-03 388 #define sk_v6_daddr __sk_common.skc_v6_daddr
efe4208f47f907 Eric Dumazet 2013-10-03 @389 #define sk_v6_rcv_saddr __sk_common.skc_v6_rcv_saddr
33cf7c90fe2f97 Eric Dumazet 2015-03-11 390 #define sk_cookie __sk_common.skc_cookie
70da268b569d32 Eric Dumazet 2015-10-08 391 #define sk_incoming_cpu __sk_common.skc_incoming_cpu
8e5eb54d303b7c Eric Dumazet 2015-10-08 392 #define sk_flags __sk_common.skc_flags
ed53d0ab761f5c Eric Dumazet 2015-10-08 393 #define sk_rxhash __sk_common.skc_rxhash
efe4208f47f907 Eric Dumazet 2013-10-03 394
43f51df4172955 Eric Dumazet 2021-11-15 395 /* early demux fields */
8b3f91332291fa Jakub Kicinski 2021-12-23 396 struct dst_entry __rcu *sk_rx_dst;
43f51df4172955 Eric Dumazet 2021-11-15 397 int sk_rx_dst_ifindex;
43f51df4172955 Eric Dumazet 2021-11-15 398 u32 sk_rx_dst_cookie;
43f51df4172955 Eric Dumazet 2021-11-15 399
^1da177e4c3f41 Linus Torvalds 2005-04-16 400 socket_lock_t sk_lock;
9115e8cd2a0c6e Eric Dumazet 2016-12-03 401 atomic_t sk_drops;
9115e8cd2a0c6e Eric Dumazet 2016-12-03 402 int sk_rcvlowat;
9115e8cd2a0c6e Eric Dumazet 2016-12-03 403 struct sk_buff_head sk_error_queue;
b178bb3dfc30d9 Eric Dumazet 2010-11-16 404 struct sk_buff_head sk_receive_queue;
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 405 /*
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 406 * The backlog queue is special, it is always used with
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 407 * the per-socket spinlock held and requires low latency
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 408 * access. Therefore we special case it's implementation.
b178bb3dfc30d9 Eric Dumazet 2010-11-16 409 * Note : rmem_alloc is in this structure to fill a hole
b178bb3dfc30d9 Eric Dumazet 2010-11-16 410 * on 64bit arches, not because its logically part of
b178bb3dfc30d9 Eric Dumazet 2010-11-16 411 * backlog.
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 412 */
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 413 struct {
b178bb3dfc30d9 Eric Dumazet 2010-11-16 414 atomic_t rmem_alloc;
b178bb3dfc30d9 Eric Dumazet 2010-11-16 415 int len;
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 416 struct sk_buff *head;
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 417 struct sk_buff *tail;
fa438ccfdfd3f6 Eric Dumazet 2007-03-04 418 } sk_backlog;
f35f821935d8df Eric Dumazet 2021-11-15 419
--
0-DAY CI Kernel Test Service
https://01.org/lkp
next prev parent reply other threads:[~2022-05-10 1:36 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-09 22:21 [PATCH v5 net-next 00/13] tcp: BIG TCP implementation Eric Dumazet
2022-05-09 22:21 ` [PATCH v5 net-next 01/13] net: add IFLA_TSO_{MAX_SIZE|SEGS} attributes Eric Dumazet
2022-05-09 22:21 ` [PATCH v5 net-next 02/13] net: allow gso_max_size to exceed 65536 Eric Dumazet
2022-05-10 1:35 ` kernel test robot [this message]
2022-05-10 2:09 ` Eric Dumazet
2022-05-10 2:20 ` Eric Dumazet
2022-05-10 3:08 ` kernel test robot
2022-05-09 22:21 ` [PATCH v5 net-next 03/13] net: limit GSO_MAX_SIZE to 524280 bytes Eric Dumazet
2022-05-09 22:21 ` [PATCH v5 net-next 04/13] tcp_cubic: make hystart_ack_delay() aware of BIG TCP Eric Dumazet
2022-05-09 22:21 ` [PATCH v5 net-next 05/13] ipv6: add struct hop_jumbo_hdr definition Eric Dumazet
2022-05-09 22:21 ` [PATCH v5 net-next 06/13] ipv6/gso: remove temporary HBH/jumbo header Eric Dumazet
2022-05-09 22:21 ` [PATCH v5 net-next 07/13] ipv6/gro: insert " Eric Dumazet
2022-05-09 22:21 ` [PATCH v5 net-next 08/13] net: allow gro_max_size to exceed 65536 Eric Dumazet
2022-05-09 22:21 ` [PATCH v5 net-next 09/13] ipv6: Add hop-by-hop header to jumbograms in ip6_output Eric Dumazet
2022-05-09 22:21 ` [PATCH v5 net-next 10/13] net: loopback: enable BIG TCP packets Eric Dumazet
2022-05-09 22:21 ` [PATCH v5 net-next 11/13] veth: " Eric Dumazet
2022-05-09 22:21 ` [PATCH v5 net-next 12/13] mlx4: support " Eric Dumazet
2022-05-09 22:21 ` [PATCH v5 net-next 13/13] mlx5: " Eric Dumazet
2022-05-09 22:30 ` Eric Dumazet
2022-05-10 1:38 ` Jakub Kicinski
2022-05-10 2:00 ` Eric Dumazet
2022-05-10 15:49 ` Kees Cook
2022-05-11 2:55 ` Kees Cook
2022-05-11 16:26 ` Jakub Kicinski
2022-05-11 17:27 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202205100923.RHeXqtNd-lkp@intel.com \
--to=lkp@intel.com \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=eric.dumazet@gmail.com \
--cc=kbuild-all@lists.01.org \
--cc=kuba@kernel.org \
--cc=lixiaoyan@google.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).