Re: [PATCH 10/30] alpha: Clean-up the panic notifier code

Guilherme G. Piccoli
2022-05-11T20:11:47Z

On 10/05/2022 11:16, Petr Mladek wrote:
> [...]
> Yeah, it is pretty strange behavior.
>
> I looked into the history. This notifier was added into the alpha code
> in 2.4.0-test2pre2. In this historic code, the default panic() code
> either rebooted after a timeout or ended in a infinite loop. There
> was not crasdump at that times.
>
> The notifier allowed to change the behavior. There were 3 notifiers:
>
> + mips and mips64 ended with blinking in panic()
> + alpha did __halt() in this srm case
>
> They both still do this. I guess that it is some historic behavior
> that people using these architectures are used to.
>
> Anyway, it makes sense to do this as the last notifier after
> dumping other information.
>
> Reviewed-by: Petr Mladek <pmladek@suse.com>
>
> Best Regards,
> Petr

Thanks a bunch for the review - added your tag for V2 =)