From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Cc: "open list:NETWORKING DRIVERS" <netdev@vger.kernel.org>,
"Jakub Kicinski" <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Paolo Abeni" <pabeni@redhat.com>,
"Eric Dumazet" <edumazet@google.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"Vivien Didelot" <vivien.didelot@gmail.com>,
"Andrew Lunn" <andrew@lunn.ch>,
"Vladimir Oltean" <olteanv@gmail.com>,
"Tobias Waldekranz" <tobias@waldekranz.com>,
"Marek Behún" <kabel@kernel.org>,
"Ansuel Smith" <ansuelsmth@gmail.com>,
"DENG Qingfang" <dqfext@gmail.com>,
"Alvin Šipraga" <alsi@bang-olufsen.dk>,
"Claudiu Manoil" <claudiu.manoil@nxp.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"UNGLinuxDriver@microchip.com" <UNGLinuxDriver@microchip.com>,
"Colin Foster" <colin.foster@in-advantage.com>,
"Linus Walleij" <linus.walleij@linaro.org>
Subject: Re: [RFC PATCH net-next 6/8] net: dsa: remove port argument from ->change_tag_protocol()
Date: Tue, 10 May 2022 22:05:38 +0000 [thread overview]
Message-ID: <20220510220536.nxecr6jqxx6kjsgs@skbuf> (raw)
In-Reply-To: <CAJq09z7AUCA9ya+8JJXGV_2NAFZ4W2jjq_OemkVokhOPBXxM_g@mail.gmail.com>
On Mon, May 09, 2022 at 02:35:48AM -0300, Luiz Angelo Daros de Luca wrote:
> > -static int rtl8365mb_change_tag_protocol(struct dsa_switch *ds, int cpu_index,
> > +static int rtl8365mb_change_tag_protocol(struct dsa_switch *ds,
> > enum dsa_tag_protocol proto)
> > {
> > struct realtek_priv *priv = ds->priv;
>
> For the rtl8365mb family, tag protocol is not a per-port property.
>
> Acked-by: Luiz Angelo Daros de Luca <luizluca@gmail.com>
Thanks. I'll be resending the series as v2 if there are no other comments.
next prev parent reply other threads:[~2022-05-10 22:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-08 15:27 [RFC PATCH net-next 0/8] DSA changes for multiple CPU ports (part 1) Vladimir Oltean
2022-05-08 15:27 ` [RFC PATCH net-next 1/8] net: dsa: felix: program host FDB entries towards PGID_CPU for tag_8021q too Vladimir Oltean
2022-05-08 15:27 ` [RFC PATCH net-next 2/8] net: dsa: felix: bring the NPI port indirection for host MDBs to surface Vladimir Oltean
2022-05-08 15:27 ` [RFC PATCH net-next 3/8] net: dsa: felix: bring the NPI port indirection for host flooding " Vladimir Oltean
2022-05-08 15:27 ` [RFC PATCH net-next 4/8] net: dsa: introduce the dsa_cpu_ports() helper Vladimir Oltean
2022-05-08 15:27 ` [RFC PATCH net-next 5/8] net: dsa: felix: manage host flooding using a specific driver callback Vladimir Oltean
2022-05-08 15:27 ` [RFC PATCH net-next 6/8] net: dsa: remove port argument from ->change_tag_protocol() Vladimir Oltean
2022-05-09 5:35 ` Luiz Angelo Daros de Luca
2022-05-10 22:05 ` Vladimir Oltean [this message]
2022-05-08 15:27 ` [RFC PATCH net-next 7/8] net: dsa: felix: dynamically determine tag_8021q CPU port for traps Vladimir Oltean
2022-05-08 15:27 ` [RFC PATCH net-next 8/8] net: dsa: felix: reimplement tagging protocol change with function pointers Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220510220536.nxecr6jqxx6kjsgs@skbuf \
--to=vladimir.oltean@nxp.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=ansuelsmth@gmail.com \
--cc=claudiu.manoil@nxp.com \
--cc=colin.foster@in-advantage.com \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=f.fainelli@gmail.com \
--cc=kabel@kernel.org \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=luizluca@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=tobias@waldekranz.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox