From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCCC5C433F5 for ; Wed, 11 May 2022 09:26:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232507AbiEKJ03 (ORCPT ); Wed, 11 May 2022 05:26:29 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47602 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240551AbiEKJ0U (ORCPT ); Wed, 11 May 2022 05:26:20 -0400 Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E81E28E19; Wed, 11 May 2022 02:26:18 -0700 (PDT) Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS DV RSA Mixed SHA256 2020 CA-1" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id AB73F2804233C; Wed, 11 May 2022 11:26:16 +0200 (CEST) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 9C65B2E9C3B; Wed, 11 May 2022 11:26:16 +0200 (CEST) Date: Wed, 11 May 2022 11:26:16 +0200 From: Lukas Wunner To: Jakub Kicinski Cc: Thomas Gleixner , Marc Zyngier , "David S. Miller" , Paolo Abeni , netdev@vger.kernel.org, linux-usb@vger.kernel.org, Steve Glendinning , UNGLinuxDriver@microchip.com, Oliver Neukum , Andre Edich , Oleksij Rempel , Martyn Welch , Gabriel Hojda , Christoph Fritz , Lino Sanfilippo , Philipp Rosenberger , Heiner Kallweit , Andrew Lunn , Russell King , Ferry Toth Subject: Re: [PATCH net-next v2 5/7] usbnet: smsc95xx: Forward PHY interrupts to PHY driver to avoid polling Message-ID: <20220511092616.GA22613@wunner.de> References: <20220505113207.487861b2@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220505113207.487861b2@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Jakub, On Thu, May 05, 2022 at 11:32:07AM -0700, Jakub Kicinski wrote: > On Tue, 3 May 2022 15:15:05 +0200 Lukas Wunner wrote: > > @@ -608,11 +618,20 @@ static void smsc95xx_status(struct usbnet *dev, struct urb *urb) > > intdata = get_unaligned_le32(urb->transfer_buffer); > > netif_dbg(dev, link, dev->net, "intdata: 0x%08X\n", intdata); > > > > + /* USB interrupts are received in softirq (tasklet) context. > > + * Switch to hardirq context to make genirq code happy. > > + */ > > + local_irq_save(flags); > > + __irq_enter_raw(); > > + > > if (intdata & INT_ENP_PHY_INT_) > > - ; > > + generic_handle_domain_irq(pdata->irqdomain, PHY_HWIRQ); > > else > > netdev_warn(dev->net, "unexpected interrupt, intdata=0x%08X\n", > > intdata); > > + > > + __irq_exit_raw(); > > + local_irq_restore(flags); > > IRQ maintainers could you cast your eyes over this? Thomas applied 792ea6a074ae ("genirq: Remove WARN_ON_ONCE() in generic_handle_domain_irq()") tonight: http://git.kernel.org/tip/tip/c/792ea6a074ae That allows me to drop the controversial __irq_enter_raw(). Jakub, do you want me to resend the full series (all 7 patches) or should I send only patch [5/7] in-reply-to this one here? Or do you prefer applying all patches except [5/7] and have me resend that single patch? Let me know what your preferred modus operandi is. Thanks, Lukas