From: Jakub Kicinski <kuba@kernel.org>
To: Edward Cree <ecree.xilinx@gmail.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com,
edumazet@google.com, Martin Habets <habetsm.xilinx@gmail.com>
Subject: Re: [PATCH net-next 3/6] eth: switch to netif_napi_add_weight()
Date: Wed, 11 May 2022 12:45:51 -0700 [thread overview]
Message-ID: <20220511124551.1766aa66@kernel.org> (raw)
In-Reply-To: <d61cf1ea-94bc-6f71-77b6-939ba9e115c4@gmail.com>
On Wed, 11 May 2022 18:57:53 +0100 Edward Cree wrote:
> > diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c
> > index eec80b024195..3f28f9861dfa 100644
> > --- a/drivers/net/ethernet/sfc/efx_channels.c
> > +++ b/drivers/net/ethernet/sfc/efx_channels.c
> > @@ -1316,8 +1316,8 @@ void efx_init_napi_channel(struct efx_channel *channel)
> > struct efx_nic *efx = channel->efx;
> >
> > channel->napi_dev = efx->net_dev;
> > - netif_napi_add(channel->napi_dev, &channel->napi_str,
> > - efx_poll, napi_weight);
> > + netif_napi_add_weight(channel->napi_dev, &channel->napi_str, efx_poll,
> > + napi_weight);
> > }
>
> This isn't really a custom weight; napi_weight is initialised to
> 64 and never changed, so probably we ought to be just using
> NAPI_POLL_WEIGHT here and end up on the non-_weight API.
> Same goes for Falcon.
Ack, I wanted to be nice. I figured this must be a stub for a module
param in your our of tree driver. Should I send a patch to remove
the non-const static napi_weight globals and switch back to non-_weight?
next prev parent reply other threads:[~2022-05-11 19:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 17:07 [PATCH net-next 0/6] net: switch drivers to netif_napi_add_weight() Jakub Kicinski
2022-05-06 17:07 ` [PATCH net-next 1/6] um: vector: switch " Jakub Kicinski
2022-05-06 17:07 ` [PATCH net-next 2/6] caif_virtio: " Jakub Kicinski
2022-05-07 6:55 ` Michael S. Tsirkin
2022-05-06 17:07 ` [PATCH net-next 3/6] eth: " Jakub Kicinski
2022-05-11 17:57 ` Edward Cree
2022-05-11 19:45 ` Jakub Kicinski [this message]
2022-05-11 21:02 ` Edward Cree
2022-05-12 7:27 ` Martin Habets
2022-05-06 17:07 ` [PATCH net-next 4/6] r8152: " Jakub Kicinski
2022-05-06 17:07 ` [PATCH net-next 5/6] net: virtio: " Jakub Kicinski
2022-05-07 1:38 ` Xuan Zhuo
2022-05-07 3:08 ` Jason Wang
2022-05-07 6:55 ` Michael S. Tsirkin
2022-05-06 17:07 ` [PATCH net-next 6/6] net: wan: " Jakub Kicinski
2022-05-08 10:50 ` [PATCH net-next 0/6] net: switch drivers " patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220511124551.1766aa66@kernel.org \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=ecree.xilinx@gmail.com \
--cc=edumazet@google.com \
--cc=habetsm.xilinx@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).