From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5BAC0C433EF for ; Wed, 11 May 2022 19:46:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347105AbiEKTp5 (ORCPT ); Wed, 11 May 2022 15:45:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55560 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238550AbiEKTpz (ORCPT ); Wed, 11 May 2022 15:45:55 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 13B2EB54 for ; Wed, 11 May 2022 12:45:54 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A362061882 for ; Wed, 11 May 2022 19:45:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9D87C340EE; Wed, 11 May 2022 19:45:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652298353; bh=9FJALjqPoUiLhyzy/15XRzGMtTPXqafD4/Tt3OcIYT8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ovd3tRuaRrGdugeB9nsBbL2BrAQYeDuoDpSkuF0yT6XLDlzZfxaLZ9fsO3QqnqliR AcBgR2hzfGJVD2CwgKFMxc5T9c/BWZtpTSTQh/INE7bwlJbzz2UYrBC5ZHP4geGCeK fAmsWdY5fpQTmztaCeFGf546vvp2lC24IUCsKgNX8dPkT7QyGeagYFycfsH7guMIA8 0SQAC0sCDHrSfyKIrvLax5GnHTTKYlMUoAQGgeRBXM08AA69l+ZGc3uS2nNV1Bja96 a8HsKtLi0TlwwYn2ViGgA4bHLdjwUJxsY0Oh2Ep8XQz+/rMnl4bXrSPGRfm9VdOnaG Bh+H6Y4XrReSQ== Date: Wed, 11 May 2022 12:45:51 -0700 From: Jakub Kicinski To: Edward Cree Cc: davem@davemloft.net, netdev@vger.kernel.org, pabeni@redhat.com, edumazet@google.com, Martin Habets Subject: Re: [PATCH net-next 3/6] eth: switch to netif_napi_add_weight() Message-ID: <20220511124551.1766aa66@kernel.org> In-Reply-To: References: <20220506170751.822862-1-kuba@kernel.org> <20220506170751.822862-4-kuba@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Wed, 11 May 2022 18:57:53 +0100 Edward Cree wrote: > > diff --git a/drivers/net/ethernet/sfc/efx_channels.c b/drivers/net/ethernet/sfc/efx_channels.c > > index eec80b024195..3f28f9861dfa 100644 > > --- a/drivers/net/ethernet/sfc/efx_channels.c > > +++ b/drivers/net/ethernet/sfc/efx_channels.c > > @@ -1316,8 +1316,8 @@ void efx_init_napi_channel(struct efx_channel *channel) > > struct efx_nic *efx = channel->efx; > > > > channel->napi_dev = efx->net_dev; > > - netif_napi_add(channel->napi_dev, &channel->napi_str, > > - efx_poll, napi_weight); > > + netif_napi_add_weight(channel->napi_dev, &channel->napi_str, efx_poll, > > + napi_weight); > > } > > This isn't really a custom weight; napi_weight is initialised to > 64 and never changed, so probably we ought to be just using > NAPI_POLL_WEIGHT here and end up on the non-_weight API. > Same goes for Falcon. Ack, I wanted to be nice. I figured this must be a stub for a module param in your our of tree driver. Should I send a patch to remove the non-const static napi_weight globals and switch back to non-_weight?