Re: [PATCH net-next 0/5] Simplifications for Broadcom and Realtek DSA taggers

[Vladimir Oltean <olteanv@gmail.com>]

On Wed, May 11, 2022 at 06:14:26PM +0300, Vladimir Oltean wrote:
> This series contains the removal of some "if" conditions from the TX hot
> path in tag_brcm and tag_rtl4_a. This is made possible by the fact that
> the DSA core has previously checked that memory allocations are not
> necessary, so there is nothing that can fail.
> 
> Vladimir Oltean (5):
>   net: dsa: tag_rtl4_a: __skb_put_padto() can never fail
>   net: dsa: tag_brcm: do not account for tag length twice when padding
>   net: dsa: tag_brcm: __skb_put_padto() can never fail
>   net: dsa: tag_brcm: eliminate conditional based on offset from
>     brcm_tag_xmit_ll
>   net: dsa: tag_brcm: use dsa_etype_header_pos_tx for legacy tag
> 
>  net/dsa/tag_brcm.c   | 51 +++++++++++++++++++-------------------------
>  net/dsa/tag_rtl4_a.c |  4 +---
>  2 files changed, 23 insertions(+), 32 deletions(-)
> 
> -- 
> 2.25.1
> 

Oh, wait, the premise behind patches 1 and 3 is invalid.
dsa_realloc_skb() only ensures there are ETH_ZLEN bytes of space in the
skb for tail taggers.

	if (unlikely(needed_tailroom && skb->len < ETH_ZLEN))
		needed_tailroom += ETH_ZLEN - skb->len;

Please treat the patch set as RFC, if we have agreement on the overall
idea I can update dsa_realloc_skb() by removing "needed_tailroom && "
from the check so the guarantee applies to all taggers.