From: Lukas Wunner <lukas@wunner.de>
To: netdev@vger.kernel.org
Cc: Andrew Lunn <andrew@lunn.ch>
Subject: Re: [PATCH net-next v3 6/7] net: phy: smsc: Cache interrupt mask
Date: Thu, 12 May 2022 14:17:17 +0200 [thread overview]
Message-ID: <20220512121717.GD4703@wunner.de> (raw)
In-Reply-To: <cf9f1b5d1b07e0fa5f78bc8557216ef04f401af5.1652343655.git.lukas@wunner.de>
On Thu, May 12, 2022 at 10:42:06AM +0200, Lukas Wunner wrote:
> Cache the interrupt mask to avoid re-reading it from the PHY upon every
> interrupt.
>
> This will simplify a subsequent commit which detects hot-removal in the
> interrupt handler and bails out.
>
> Analyzing and debugging PHY transactions also becomes simpler if such
> redundant reads are avoided.
>
> Last not least, interrupt overhead and latency is slightly improved.
>
> Tested-by: Oleksij Rempel <o.rempel@pengutronix.de> # LAN9514/9512/9500
> Tested-by: Ferry Toth <fntoth@gmail.com> # LAN9514
> Signed-off-by: Lukas Wunner <lukas@wunner.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew kindly provided this tag here:
https://lore.kernel.org/netdev/YnGsDtscYkh28PFm@lunn.ch/
Forgot to add it to the commit.
Sending it in separately so patchwork picks it up.
My apologies for the inconvenience.
next prev parent reply other threads:[~2022-05-12 12:17 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 8:42 [PATCH net-next v3 0/7] Polling be gone on LAN95xx Lukas Wunner
2022-05-12 8:42 ` [PATCH net-next v3 1/7] usbnet: Run unregister_netdev() before unbind() again Lukas Wunner
2022-05-12 8:42 ` [PATCH net-next v3 2/7] usbnet: smsc95xx: Don't clear read-only PHY interrupt Lukas Wunner
2022-05-12 11:57 ` Lukas Wunner
2022-05-12 8:42 ` [PATCH net-next v3 3/7] usbnet: smsc95xx: Don't reset PHY behind PHY driver's back Lukas Wunner
2022-05-12 12:12 ` Lukas Wunner
2022-05-12 8:42 ` [PATCH net-next v3 4/7] usbnet: smsc95xx: Avoid link settings race on interrupt reception Lukas Wunner
2022-05-12 12:15 ` Lukas Wunner
2022-05-12 8:42 ` [PATCH net-next v3 5/7] usbnet: smsc95xx: Forward PHY interrupts to PHY driver to avoid polling Lukas Wunner
[not found] ` <CGME20220517101846eucas1p2c132f7e7032ed00996e222e9cc6cdf99@eucas1p2.samsung.com>
2022-05-17 10:18 ` Marek Szyprowski
2022-05-19 19:08 ` Lukas Wunner
2022-05-19 21:22 ` Marek Szyprowski
2022-05-23 9:43 ` Lukas Wunner
2022-05-23 11:38 ` Marek Szyprowski
2022-05-23 12:34 ` Andrew Lunn
2022-05-23 13:47 ` Lukas Wunner
2022-05-24 0:52 ` Andrew Lunn
2022-05-24 1:08 ` Andrew Lunn
2022-05-24 6:16 ` Marek Szyprowski
2022-05-24 12:03 ` Andrew Lunn
2022-05-26 13:55 ` Lukas Wunner
2022-05-24 12:13 ` Lukas Wunner
2022-06-06 1:28 ` Andrew Lunn
2022-08-26 6:51 ` Marek Szyprowski
2022-08-26 7:19 ` Lukas Wunner
2022-08-26 7:41 ` Marek Szyprowski
2022-08-26 7:53 ` Lukas Wunner
2022-08-26 8:29 ` Marek Szyprowski
2022-08-29 11:40 ` Marek Szyprowski
2022-09-18 19:13 ` Lukas Wunner
2022-09-18 20:41 ` Florian Fainelli
2022-09-18 20:55 ` Lukas Wunner
2022-09-18 22:11 ` Florian Fainelli
2022-09-23 4:20 ` Lukas Wunner
2022-09-22 13:21 ` Marek Szyprowski
2022-05-12 8:42 ` [PATCH net-next v3 6/7] net: phy: smsc: Cache interrupt mask Lukas Wunner
2022-05-12 12:17 ` Lukas Wunner [this message]
2022-05-12 8:42 ` [PATCH net-next v3 7/7] net: phy: smsc: Cope with hot-removal in interrupt handler Lukas Wunner
2022-05-12 12:19 ` Lukas Wunner
2022-05-13 10:40 ` [PATCH net-next v3 0/7] Polling be gone on LAN95xx patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512121717.GD4703@wunner.de \
--to=lukas@wunner.de \
--cc=andrew@lunn.ch \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).