From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id D9DBEC433F5
	for <netdev@archiver.kernel.org>; Thu, 12 May 2022 22:51:43 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1359310AbiELWvm (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Thu, 12 May 2022 18:51:42 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38048 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1359296AbiELWvl (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 12 May 2022 18:51:41 -0400
Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9859B7092B;
        Thu, 12 May 2022 15:51:40 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 598F3B82910;
        Thu, 12 May 2022 22:51:39 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id ADD30C34113;
        Thu, 12 May 2022 22:51:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1652395898;
        bh=l9FI+xPaIYCA8qXMiCGdIY4O2JO8Tx/QE9A+vCNwMaI=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=bKdcoXdlVkkR807/3DKbIpUXM0kRj7bK/6xqRTYNYrKtZtY66CPaQZnCZElkKD3D0
         xsqMpqxVorjEG3ouvDe+jzVleXiRYq8a+N2iXdxk7jUPwv1aL2BQJkWtg7vkmvlgNU
         vBGFaYNZrVODJWagbw/PvBUrCd31PdADHUJjKwIiLA9z424EjV7LwHgJi8aVUGemP6
         DcQNq69erTsz5h3KQiqAfirCAkbMa1Gyr/wxTod2SjRBK39JKOBRROea959Hdg8YGL
         0TSR2vblyQAwIvvHyoQ8tQSRF27rvvtPJVkAQz3X15PX91a8ixQgIvfPXJ3ETcnhf/
         Z+IttVBhP7ruQ==
Date:   Thu, 12 May 2022 15:51:36 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Eric Dumazet <edumazet@google.com>
Cc:     syzbot <syzbot+8ed8fc4c57e9dcf23ca6@syzkaller.appspotmail.com>,
        David Miller <davem@davemloft.net>,
        Jamal Hadi Salim <jhs@mojatatu.com>,
        Jiri Pirko <jiri@resnulli.us>,
        LKML <linux-kernel@vger.kernel.org>,
        netdev <netdev@vger.kernel.org>, Paolo Abeni <pabeni@redhat.com>,
        syzkaller-bugs <syzkaller-bugs@googlegroups.com>,
        Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: [syzbot] UBSAN: shift-out-of-bounds in tcf_pedit_init
Message-ID: <20220512155136.70554388@kernel.org>
In-Reply-To: <CANn89i+XHh1An6fDA0CH1Fb2k_-G8_CCzEmXGKqB4tRAMH9s4w@mail.gmail.com>
References: <0000000000005f1a8805ded719cc@google.com>
        <CANn89i+XHh1An6fDA0CH1Fb2k_-G8_CCzEmXGKqB4tRAMH9s4w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Thu, 12 May 2022 14:19:51 -0700 Eric Dumazet wrote:
> On Thu, May 12, 2022 at 2:18 PM syzbot
> > This report is generated by a bot. It may contain errors.
> > See https://goo.gl/tpsmEJ for more information about syzbot.
> > syzbot engineers can be reached at syzkaller@googlegroups.com.
> >
> > syzbot will keep track of this issue. See:
> > https://goo.gl/tpsmEJ#status for how to communicate with syzbot.
> > syzbot can test patches for this issue, for details see:
> > https://goo.gl/tpsmEJ#testing-patches  
> 
> As mentioned earlier, this came with
> 
> commit 8b796475fd7882663a870456466a4fb315cc1bd6
> Author: Paolo Abeni <pabeni@redhat.com>
> Date:   Tue May 10 16:57:34 2022 +0200
> 
>     net/sched: act_pedit: really ensure the skb is writable

Came in as in new stack trace for an old/existing bug, right?
Nothing checks the shift so it'd have already tripped UBSAN 
later on in tcf_pedit_act(), anyway.