From: Jakub Kicinski <kuba@kernel.org>
To: Suman Ghosh <sumang@marvell.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<sgoutham@marvell.com>, <sbhatta@marvell.com>,
<gakula@marvell.com>, <Sunil.Goutham@cavium.com>,
<hkelam@marvell.com>, <colin.king@intel.com>,
<netdev@vger.kernel.org>
Subject: Re: [net-next PATCH] octeontx2-pf: Add support for adaptive interrupt coalescing
Date: Thu, 12 May 2022 16:58:42 -0700 [thread overview]
Message-ID: <20220512165842.4f0ed0f8@kernel.org> (raw)
In-Reply-To: <20220512071912.672009-1-sumang@marvell.com>
On Thu, 12 May 2022 12:49:12 +0530 Suman Ghosh wrote:
> Added support for adaptive IRQ coalescing. It uses net_dim
> algorithm to find the suitable delay/IRQ count based on the
> current packet rate.
>
> Signed-off-by: Suman Ghosh <sumang@marvell.com>
> Reviewed-by: Sunil Kovvuri Goutham <sgoutham@marvell.com>
You still claim this is tested? How can it work if you're not changing
.supported_coalesce_params? Do we have a bug in the core?
> + /* Check and update coalesce status */
> + if ((pfvf->flags & OTX2_FLAG_ADPTV_INT_COAL_ENABLED) ==
> + OTX2_FLAG_ADPTV_INT_COAL_ENABLED) {
> + priv_coalesce_status = 1;
> + if (!ec->use_adaptive_rx_coalesce || !ec->use_adaptive_tx_coalesce)
> + pfvf->flags &= ~OTX2_FLAG_ADPTV_INT_COAL_ENABLED;
> + } else {
> + priv_coalesce_status = 0;
> + if (ec->use_adaptive_rx_coalesce || ec->use_adaptive_tx_coalesce)
> + pfvf->flags |= OTX2_FLAG_ADPTV_INT_COAL_ENABLED;
> + }
Won't this flip-flop the flag? You should probably reject
adaptive_rx != adaptive_tx.
> /* Re-enable interrupts */
> otx2_write64(pfvf, NIX_LF_CINTX_ENA_W1S(cq_poll->cint_idx),
> - BIT_ULL(0));
> + BIT_ULL(0));
Unrelated and possibly misalinged?
next prev parent reply other threads:[~2022-05-12 23:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-12 7:19 [net-next PATCH] octeontx2-pf: Add support for adaptive interrupt coalescing Suman Ghosh
2022-05-12 23:58 ` Jakub Kicinski [this message]
2022-05-16 4:45 ` [EXT] " Suman Ghosh
2022-05-16 10:54 ` Suman Ghosh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220512165842.4f0ed0f8@kernel.org \
--to=kuba@kernel.org \
--cc=Sunil.Goutham@cavium.com \
--cc=colin.king@intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkelam@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbhatta@marvell.com \
--cc=sgoutham@marvell.com \
--cc=sumang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).