From: Jakub Kicinski <kuba@kernel.org>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
linux-can@vger.kernel.org, kernel@pengutronix.de,
Jarkko Nikula <jarkko.nikula@linux.intel.com>,
Chee Hou Ong <chee.houx.ong@intel.com>,
Aman Kumar <aman.kumar@intel.com>,
Pallavi Kumari <kumari.pallavi@intel.com>,
stable@vger.kernel.org
Subject: Re: [PATCH net 1/2] Revert "can: m_can: pci: use custom bit timings for Elkhart Lake"
Date: Fri, 13 May 2022 10:21:45 -0700 [thread overview]
Message-ID: <20220513102145.748db22c@kernel.org> (raw)
In-Reply-To: <20220513130819.386012-2-mkl@pengutronix.de>
On Fri, 13 May 2022 15:08:18 +0200 Marc Kleine-Budde wrote:
> From: Jarkko Nikula <jarkko.nikula@linux.intel.com>
>
> This reverts commit 0e8ffdf3b86dfd44b651f91b12fcae76c25c453b.
>
> Commit 0e8ffdf3b86d ("can: m_can: pci: use custom bit timings for
> Elkhart Lake") broke the test case using bitrate switching.
>
> | ip link set can0 up type can bitrate 500000 dbitrate 4000000 fd on
> | ip link set can1 up type can bitrate 500000 dbitrate 4000000 fd on
> | candump can0 &
> | cangen can1 -I 0x800 -L 64 -e -fb \
> | -D 11223344deadbeef55667788feedf00daabbccdd44332211 -n 1 -v -v
>
> Above commit does everything correctly according to the datasheet.
> However datasheet wasn't correct.
>
> I got confirmation from hardware engineers that the actual CAN
> hardware on Intel Elkhart Lake is based on M_CAN version v3.2.0.
> Datasheet was mirroring values from an another specification which was
> based on earlier M_CAN version leading to wrong bit timings.
>
> Therefore revert the commit and switch back to common bit timings.
>
> Fixes: 0e8ffdf3b86d ("can: m_can: pci: use custom bit timings for Elkhart Lake")
> Link: https://lore.kernel.org/all/20220512124144.536850-1-jarkko.nikula@linux.intel.com
> Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Reported-by: Chee Hou Ong <chee.houx.ong@intel.com>
> Reported-by: Aman Kumar <aman.kumar@intel.com>
> Reported-by: Pallavi Kumari <kumari.pallavi@intel.com>
> Cc: <stable@vger.kernel.org> # v5.16+
> Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
nit: the hash in the fixes tag should be:
Fixes: ea4c1787685d ("can: m_can: pci: use custom bit timings for Elkhart Lake")
Do you want to respin or is the can tree non-rebasable?
next prev parent reply other threads:[~2022-05-13 17:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 13:08 [PATCH net 0/2] pull-request: can 2022-05-13 Marc Kleine-Budde
2022-05-13 13:08 ` [PATCH net 1/2] Revert "can: m_can: pci: use custom bit timings for Elkhart Lake" Marc Kleine-Budde
2022-05-13 17:21 ` Jakub Kicinski [this message]
2022-05-14 19:00 ` Marc Kleine-Budde
2022-05-18 12:47 ` Jarkko Nikula
2022-05-13 13:08 ` [PATCH net 2/2] can: m_can: remove support for custom bit timing, take #2 Marc Kleine-Budde
-- strict thread matches above, loose matches on Subject: below --
2022-05-14 18:57 [PATCH net 0/2] pull-request: can 2022-05-14 Marc Kleine-Budde
2022-05-14 18:57 ` [PATCH net 1/2] Revert "can: m_can: pci: use custom bit timings for Elkhart Lake" Marc Kleine-Budde
2022-05-16 9:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220513102145.748db22c@kernel.org \
--to=kuba@kernel.org \
--cc=aman.kumar@intel.com \
--cc=chee.houx.ong@intel.com \
--cc=davem@davemloft.net \
--cc=jarkko.nikula@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=kumari.pallavi@intel.com \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).