From: Eric Dumazet <eric.dumazet@gmail.com>
To: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Cc: netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: [PATCH net-next 0/4] net: polish skb defer freeing
Date: Sun, 15 May 2022 21:24:52 -0700 [thread overview]
Message-ID: <20220516042456.3014395-1-eric.dumazet@gmail.com> (raw)
From: Eric Dumazet <edumazet@google.com>
While testing this recently added feature on a variety
of platforms/configurations, I found the following issues:
1) A race leading to concurrent calls to smp_call_function_single_async()
2) Missed opportunity to use napi_consume_skb()
3) Need to limit the max length of the per-cpu lists.
4) Process the per-cpu list more frequently, for the
(unusual) case where net_rx_action() has mutiple
napi_poll() to process per round.
Eric Dumazet (4):
net: fix possible race in skb_attempt_defer_free()
net: use napi_consume_skb() in skb_defer_free_flush()
net: add skb_defer_max sysctl
net: call skb_defer_free_flush() before each napi_poll()
Documentation/admin-guide/sysctl/net.rst | 8 ++++++++
include/linux/netdevice.h | 1 +
net/core/dev.c | 15 ++++++++++-----
net/core/dev.h | 2 +-
net/core/skbuff.c | 18 ++++++++++--------
net/core/sysctl_net_core.c | 8 ++++++++
6 files changed, 38 insertions(+), 14 deletions(-)
--
2.36.0.550.gb090851708-goog
next reply other threads:[~2022-05-16 4:25 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 4:24 Eric Dumazet [this message]
2022-05-16 4:24 ` [PATCH net-next 1/4] net: fix possible race in skb_attempt_defer_free() Eric Dumazet
2022-05-16 18:15 ` Jakub Kicinski
2022-05-16 18:24 ` Eric Dumazet
2022-05-16 18:54 ` Jakub Kicinski
2022-05-16 4:24 ` [PATCH net-next 2/4] net: use napi_consume_skb() in skb_defer_free_flush() Eric Dumazet
2022-05-16 4:24 ` [PATCH net-next 3/4] net: add skb_defer_max sysctl Eric Dumazet
2022-05-16 20:39 ` Jakub Kicinski
2022-05-16 20:43 ` Eric Dumazet
2022-05-16 4:24 ` [PATCH net-next 4/4] net: call skb_defer_free_flush() before each napi_poll() Eric Dumazet
2022-05-16 18:21 ` Jakub Kicinski
2022-05-16 18:26 ` Eric Dumazet
2022-05-16 18:56 ` Jakub Kicinski
2022-05-16 10:40 ` [PATCH net-next 0/4] net: polish skb defer freeing patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220516042456.3014395-1-eric.dumazet@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).