From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 89D3FC433EF
	for <netdev@archiver.kernel.org>; Tue, 17 May 2022 00:43:12 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S232208AbiEQAnL (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Mon, 16 May 2022 20:43:11 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38990 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S230472AbiEQAnJ (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 16 May 2022 20:43:09 -0400
Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8159919C1D
        for <netdev@vger.kernel.org>; Mon, 16 May 2022 17:43:07 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by ams.source.kernel.org (Postfix) with ESMTPS id 1A750B810F3
        for <netdev@vger.kernel.org>; Tue, 17 May 2022 00:43:06 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 66772C385B8;
        Tue, 17 May 2022 00:43:04 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1652748184;
        bh=U8KXz74idEs0srzsSzRIu4fFqSd2UV0HpsQcLsMADXU=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=IMNHxTlYc9o1G2STFl0ypl5qJc2jwCjINPSmhpwNLqRuvH0yMdDWu5/+UiAc3LyHy
         PvGJgtMGVouCysNbM/vhBTzKRvcCtXcfom6rcpFUwrdQsVyiAOpiKCyVZZza5jVolH
         VabjTnnX4/KWLvKWh2mH6xALgOHc6Y1uPew0HQu8N1VVzfwvKU5tWtJYMysxb++A82
         P9yLq07Am1rUieav25ICGSB2rPXZXAXD28oULQqWER7P0spwq/iQAVSh4TaqK34OL+
         MhghiOM4nMum/zEp8SuhjwwH5V5aqs7UZgL9/mDfqXWPF4D7s1zQ6fGH9MKrlDaGAT
         /fhBaTAOIa08Q==
Date:   Mon, 16 May 2022 17:43:03 -0700
From:   Jakub Kicinski <kuba@kernel.org>
To:     Jonathan Lemon <jonathan.lemon@gmail.com>
Cc:     netdev@vger.kernel.org, richardcochran@gmail.com,
        davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
        kernel-team@fb.com
Subject: Re: [PATCH net-next v3 02/10] ptp: ocp: add Celestica timecard PCI
 ids
Message-ID: <20220516174303.73de08ae@kernel.org>
In-Reply-To: <20220513225924.1655-3-jonathan.lemon@gmail.com>
References: <20220513225924.1655-1-jonathan.lemon@gmail.com>
        <20220513225924.1655-3-jonathan.lemon@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, 13 May 2022 15:59:16 -0700 Jonathan Lemon wrote:
> +#ifndef PCI_VENDOR_ID_CELESTICA
> +#define PCI_VENDOR_ID_CELESTICA 0x18d4
> +#endif
> +
> +#ifndef PCI_DEVICE_ID_CELESTICA_TIMECARD
> +#define PCI_DEVICE_ID_CELESTICA_TIMECARD 0x1008
> +#endif

The ifdefs are unnecessary, these kind of constructs are often used out
of tree when one does not control the headers, but not sure what purpose
they'd serve upstream?