From: Jakub Kicinski <kuba@kernel.org>
To: Kalle Valo <kvalo@kernel.org>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, johannes@sipsolutions.net,
alex.aring@gmail.com, stefan@datenfreihafen.org,
mareklindner@neomailbox.ch, sw@simonwunderlich.de, a@unstable.cc,
sven@narfation.org, linux-wireless@vger.kernel.org,
linux-wpan@vger.kernel.org
Subject: Re: [PATCH net-next] net: ifdefy the wireless pointers in struct net_device
Date: Tue, 17 May 2022 10:32:02 -0700 [thread overview]
Message-ID: <20220517103202.6613c5ef@kernel.org> (raw)
In-Reply-To: <87zgjgwza1.fsf@kernel.org>
On Tue, 17 May 2022 07:36:54 +0300 Kalle Valo wrote:
> > +void cfg80211_unregister_netdevice(struct net_device *dev)
> > +{
> > + cfg80211_unregister_wdev(dev->ieee80211_ptr);
> > +}
> > +EXPORT_SYMBOL(cfg80211_unregister_netdevice);
>
> Why moving this to a proper function? Just curious, I couldn't figure it
> out.
Sorry, I went too far with the "explain what not why".
The header is included in places which get built without
WIRELESS while the C source is not.
next prev parent reply other threads:[~2022-05-17 17:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 21:56 [PATCH net-next] net: ifdefy the wireless pointers in struct net_device Jakub Kicinski
2022-05-17 2:12 ` Florian Fainelli
2022-05-17 7:48 ` Johannes Berg
2022-05-17 17:37 ` Jakub Kicinski
2022-05-17 18:16 ` Johannes Berg
2022-05-17 19:33 ` Alexander Aring
2022-05-17 19:49 ` Jakub Kicinski
2022-05-17 4:36 ` Kalle Valo
2022-05-17 17:32 ` Jakub Kicinski [this message]
2022-05-17 7:08 ` Stefan Schmidt
2022-05-17 7:51 ` Johannes Berg
2022-05-17 17:44 ` Jakub Kicinski
2022-05-17 18:03 ` Johannes Berg
2022-05-17 11:49 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517103202.6613c5ef@kernel.org \
--to=kuba@kernel.org \
--cc=a@unstable.cc \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefan@datenfreihafen.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).