* [RFC PATCH] net: fec: Avoid to allocate rx buffer using ATOMIC in ndo_open
@ 2022-05-17 10:05 Michael Trimarchi
2022-05-17 22:27 ` Jakub Kicinski
0 siblings, 1 reply; 2+ messages in thread
From: Michael Trimarchi @ 2022-05-17 10:05 UTC (permalink / raw)
To: Joakim Zhang, Liam Girdwood
Cc: Jakub Kicinski, Eric Dumazet, Paolo Abeni, netdev, linux-kernel
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
drivers/net/ethernet/freescale/fec_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 9f33ec838b52..09eb6ea9a584 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3076,7 +3076,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue)
rxq = fep->rx_queue[queue];
bdp = rxq->bd.base;
for (i = 0; i < rxq->bd.ring_size; i++) {
- skb = netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE);
+ skb = __netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE, GFP_KERNEL);
if (!skb)
goto err_alloc;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [RFC PATCH] net: fec: Avoid to allocate rx buffer using ATOMIC in ndo_open
2022-05-17 10:05 [RFC PATCH] net: fec: Avoid to allocate rx buffer using ATOMIC in ndo_open Michael Trimarchi
@ 2022-05-17 22:27 ` Jakub Kicinski
0 siblings, 0 replies; 2+ messages in thread
From: Jakub Kicinski @ 2022-05-17 22:27 UTC (permalink / raw)
To: Michael Trimarchi
Cc: Joakim Zhang, Liam Girdwood, Eric Dumazet, Paolo Abeni, netdev,
linux-kernel
On Tue, 17 May 2022 12:05:44 +0200 Michael Trimarchi wrote:
> Subject: [RFC PATCH] net: fec: Avoid to allocate rx buffer using ATOMIC in ndo_open
nit: "Avoid allocating"
We need a commit message, guessing your motivation something like this
would be enough IMHO:
Make ndo_open less sensitive to memory pressure.
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> drivers/net/ethernet/freescale/fec_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
> index 9f33ec838b52..09eb6ea9a584 100644
> --- a/drivers/net/ethernet/freescale/fec_main.c
> +++ b/drivers/net/ethernet/freescale/fec_main.c
> @@ -3076,7 +3076,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue)
> rxq = fep->rx_queue[queue];
> bdp = rxq->bd.base;
> for (i = 0; i < rxq->bd.ring_size; i++) {
> - skb = netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE);
> + skb = __netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE, GFP_KERNEL);
> if (!skb)
> goto err_alloc;
>
The patch LGTM, feel free to repost as non-RFC.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-17 22:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-17 10:05 [RFC PATCH] net: fec: Avoid to allocate rx buffer using ATOMIC in ndo_open Michael Trimarchi
2022-05-17 22:27 ` Jakub Kicinski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).