From: Jakub Kicinski <kuba@kernel.org>
To: Yang Yingliang <yangyingliang@huawei.com>, <wellslutw@gmail.com>
Cc: <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<andrew@lunn.ch>, <pabeni@redhat.com>, <davem@davemloft.net>
Subject: Re: [PATCH -next] net: ethernet: sunplus: add missing of_node_put() in spl2sw_mdio_init()
Date: Tue, 17 May 2022 17:47:40 -0700 [thread overview]
Message-ID: <20220517174740.2fe90ebb@kernel.org> (raw)
In-Reply-To: <20220516143734.1598316-1-yangyingliang@huawei.com>
On Mon, 16 May 2022 22:37:34 +0800 Yang Yingliang wrote:
> of_get_child_by_name() returns device node pointer with refcount
> incremented. The refcount should be decremented before returning
> from spl2sw_mdio_init().
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Please add a Fixes tag, even if the change in question is only in
linux-next.
Wells Lu, the expectation for networking maintainers is that you will
review patches for your driver without 24, max 48 hours (not counting
weekends). Please respond with feedback or Acked-by / Reviewed-by tags
now that your driver has been merged. Thanks.
prev parent reply other threads:[~2022-05-18 0:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 14:37 [PATCH -next] net: ethernet: sunplus: add missing of_node_put() in spl2sw_mdio_init() Yang Yingliang
2022-05-18 0:47 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517174740.2fe90ebb@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wellslutw@gmail.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).