From: Jakub Kicinski <kuba@kernel.org>
To: Peng Wu <wupeng58@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>,
<hkallweit1@gmail.com>, <bhelgaas@google.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<liwei391@huawei.com>
Subject: Re: [PATCH] sfc/siena: fix driver suspend/resume methods
Date: Tue, 17 May 2022 17:55:19 -0700 [thread overview]
Message-ID: <20220517175519.0b04e58b@kernel.org> (raw)
In-Reply-To: <20220517012334.122677-1-wupeng58@huawei.com>
On Tue, 17 May 2022 01:23:34 +0000 Peng Wu wrote:
> Fix the missing pci_disable_device() before return
> from efx_pm_resume() in the error handling case.
>
> Meanwhile, drivers should do this:
> .resume()
> pci_enable_device()
> .suspend()
> pci_disable_device()
>
> Signed-off-by: Peng Wu <wupeng58@huawei.com>
Won't the remove function no disable the device, anyway?
If the patch is indeed needed please add a Fixes tag pointing to where
the buggy code was added and repost.
Also since this file is a copy of drivers/net/ethernet/sfc/efx.c
I'm not sure why you're only patching this instance but not the
original.
prev parent reply other threads:[~2022-05-18 0:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 1:23 [PATCH] sfc/siena: fix driver suspend/resume methods Peng Wu
2022-05-18 0:55 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517175519.0b04e58b@kernel.org \
--to=kuba@kernel.org \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liwei391@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=wupeng58@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).