From: Mat Martineau <mathew.j.martineau@linux.intel.com>
To: netdev@vger.kernel.org
Cc: Mat Martineau <mathew.j.martineau@linux.intel.com>,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
edumazet@google.com, matthieu.baerts@tessares.net,
mptcp@lists.linux.dev
Subject: [PATCH net 0/2] mptcp: Fix checksum byte order on little-endian
Date: Tue, 17 May 2022 11:02:10 -0700 [thread overview]
Message-ID: <20220517180212.92597-1-mathew.j.martineau@linux.intel.com> (raw)
These patches address a bug in the byte ordering of MPTCP checksums on
little-endian architectures. The __sum16 type is always big endian, but
was being cast to u16 and then byte-swapped (on little-endian archs)
when reading/writing the checksum field in MPTCP option headers.
MPTCP checksums are off by default, but are enabled if one or both peers
request it in the SYN/SYNACK handshake.
The corrected code is verified to interoperate between big-endian and
little-endian machines.
Patch 1 fixes the checksum byte order, patch 2 partially mitigates
interoperation with peers sending bad checksums by falling back to TCP
instead of resetting the connection.
Mat Martineau (1):
mptcp: Do TCP fallback on early DSS checksum failure
Paolo Abeni (1):
mptcp: fix checksum byte order
net/mptcp/options.c | 36 ++++++++++++++++++++++++------------
net/mptcp/protocol.h | 5 +++--
net/mptcp/subflow.c | 23 +++++++++++++++++++----
3 files changed, 46 insertions(+), 18 deletions(-)
base-commit: edf410cb74dc612fd47ef5be319c5a0bcd6e6ccd
--
2.36.1
next reply other threads:[~2022-05-17 18:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-17 18:02 Mat Martineau [this message]
2022-05-17 18:02 ` [PATCH net 1/2] mptcp: fix checksum byte order Mat Martineau
2022-05-17 18:02 ` [PATCH net 2/2] mptcp: Do TCP fallback on early DSS checksum failure Mat Martineau
2022-05-18 12:30 ` [PATCH net 0/2] mptcp: Fix checksum byte order on little-endian patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220517180212.92597-1-mathew.j.martineau@linux.intel.com \
--to=mathew.j.martineau@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=matthieu.baerts@tessares.net \
--cc=mptcp@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox