From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id F34CDC433F5 for ; Wed, 18 May 2022 06:20:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230479AbiERGUN (ORCPT ); Wed, 18 May 2022 02:20:13 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46736 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230392AbiERGUM (ORCPT ); Wed, 18 May 2022 02:20:12 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D642C0386 for ; Tue, 17 May 2022 23:20:11 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id k126so518610wme.2 for ; Tue, 17 May 2022 23:20:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amarulasolutions.com; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NY8GpNn3ouqYPF3eic3S/ZQvlCNUF5XAtgPk9wl+rm0=; b=b8c46vdYjeWBbn0XMdRJguDoxnmC5sZgPyGV4+/mX8+WOLitHXwcKu1OKRIVtijzxg DWaVcdVj1CJHc8VV888C2pNoxc4NXxYGoPFfYTWN072HzrAxgt7K5EKXhBe8U0WX49tj DDyUxOo1q2sARKc/5wxojJqa0NVRmJ4RgLgyg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=NY8GpNn3ouqYPF3eic3S/ZQvlCNUF5XAtgPk9wl+rm0=; b=e9Uq0uOmP4FPdSBYIQCrGEqdiJ1Jy+c0NmFOhTCngozRMZYLIU7/UrQIplbrmGgq3w YUlHV70HIjNONh/5lH/91L6+TSQUuROhzIDwOezl7mQBejcgtR3p2UgD9m684EGE3eQU 4pL2IiPlvWU0P0s2zQ7HUENe8M2hc/GbVLF1eUW9m36rdjBvYFqcUqGFnN5U5KKpS6NA FnhCMrtyw+hcFPzhyz7pLh9Plak+pvHUU6Xy9LNDcXwgyBQoDzYpDLJDHT07sNwfxhUP 2FJY3fgLoGBnnTgeNVTGSKbGswOKhhZh//r/wOdGyhp0B01xxJTh9RdUIgQX/u10i5OE 93LQ== X-Gm-Message-State: AOAM5311fzXD/ufJQJvQ4DWjeyLV5tH0KAWyhhr0gMb8wjBsFzX4rr8k IZu6HIDoIX3zBu7anGD4VxuQug== X-Google-Smtp-Source: ABdhPJwOzfUZghq0VDBdWhiOnXKgqnB9u9p8Iq0u1TSE0tbyeZdUma+QuQzT+kW4AWR+SvRpVDySPw== X-Received: by 2002:a05:600c:3d8b:b0:397:87e:c8df with SMTP id bi11-20020a05600c3d8b00b00397087ec8dfmr11998118wmb.187.1652854810094; Tue, 17 May 2022 23:20:10 -0700 (PDT) Received: from localhost.localdomain (mob-37-180-41-238.net.vodafone.it. [37.180.41.238]) by smtp.gmail.com with ESMTPSA id u23-20020a05600c00d700b003942a244f42sm4105169wmm.27.2022.05.17.23.20.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 May 2022 23:20:09 -0700 (PDT) From: Michael Trimarchi To: Joakim Zhang , Liam Girdwood , Jakub Kicinski Cc: Eric Dumazet , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open Date: Wed, 18 May 2022 08:20:07 +0200 Message-Id: <20220518062007.10056-1-michael@amarulasolutions.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Make ndo_open less sensitive to memory pressure. Signed-off-by: Michael Trimarchi --- Change: - Adjust the commit message addressing the comments in RFC version --- drivers/net/ethernet/freescale/fec_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c index 9f33ec838b52..09eb6ea9a584 100644 --- a/drivers/net/ethernet/freescale/fec_main.c +++ b/drivers/net/ethernet/freescale/fec_main.c @@ -3076,7 +3076,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue) rxq = fep->rx_queue[queue]; bdp = rxq->bd.base; for (i = 0; i < rxq->bd.ring_size; i++) { - skb = netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE); + skb = __netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE, GFP_KERNEL); if (!skb) goto err_alloc; -- 2.25.1