From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29E27C433F5 for ; Wed, 18 May 2022 06:50:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231625AbiERGuP (ORCPT ); Wed, 18 May 2022 02:50:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231515AbiERGuL (ORCPT ); Wed, 18 May 2022 02:50:11 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53E22222A6 for ; Tue, 17 May 2022 23:49:51 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 09EF7B81E96 for ; Wed, 18 May 2022 06:49:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id AD7F0C385A9; Wed, 18 May 2022 06:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1652856588; bh=3HyCebgutehj97u9eF+nBk+cDHl9asxjvET1VGm/jRs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZLzrEF4zaBlIEFyL9mOkEbh8U64JiW2iiGID2RqhvJtQT9WckAv2NgUP3R2gXIwPf Fu7FlTLwxbDDLLpS0G5p/FZ80D9bRL1gObPpzTSlHDxQ7Xa5y4jgB8qgE7yrmtNCEf l7x+LE65OZARCPMbmJ/ooUqx55QrKAgWYGHp02lf/D7qunRQxRr6M1D89sOv6H8cGp RejmA/bpd3aHkWL+pXpMOe3/bab5w7HEp23/vyf1YHqUUPJZB2YDt45GJW9mbuHKU2 zC2W8C8J/BNJEzE5rxXE/EVDk5qMYGMME+uK6eb08bMrQ9605bAGhephISvh+7/pei cMAkOEAB7uWVg== From: Saeed Mahameed To: "David S. Miller" , Jakub Kicinski , Paolo Abeni Cc: netdev@vger.kernel.org, Tariq Toukan , Moshe Shemesh , Saeed Mahameed Subject: [net-next 06/16] net/mlx5e: Allocate virtually contiguous memory for VLANs list Date: Tue, 17 May 2022 23:49:28 -0700 Message-Id: <20220518064938.128220-7-saeed@kernel.org> X-Mailer: git-send-email 2.36.1 In-Reply-To: <20220518064938.128220-1-saeed@kernel.org> References: <20220518064938.128220-1-saeed@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Tariq Toukan Physical continuity is not necessary, and requested allocation size might be larger than PAGE_SIZE. Hence, use v-alloc/free API. Signed-off-by: Tariq Toukan Reviewed-by: Moshe Shemesh Signed-off-by: Saeed Mahameed --- drivers/net/ethernet/mellanox/mlx5/core/en_fs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c b/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c index aeff1d972a46..d2f0773f95c6 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_fs.c @@ -155,7 +155,7 @@ static int mlx5e_vport_context_update_vlans(struct mlx5e_priv *priv) list_size = max_list_size; } - vlans = kcalloc(list_size, sizeof(*vlans), GFP_KERNEL); + vlans = kvcalloc(list_size, sizeof(*vlans), GFP_KERNEL); if (!vlans) return -ENOMEM; @@ -171,7 +171,7 @@ static int mlx5e_vport_context_update_vlans(struct mlx5e_priv *priv) netdev_err(ndev, "Failed to modify vport vlans list err(%d)\n", err); - kfree(vlans); + kvfree(vlans); return err; } -- 2.36.1