From: Jakub Kicinski <kuba@kernel.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: davem@davemloft.net, netdev@vger.kernel.org, edumazet@google.com,
pabeni@redhat.com, Stefan Schmidt <stefan@datenfreihafen.org>,
alex.aring@gmail.com, mareklindner@neomailbox.ch,
sw@simonwunderlich.de, a@unstable.cc, sven@narfation.org,
linux-wireless@vger.kernel.org, linux-wpan@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: ifdefy the wireless pointers in struct net_device
Date: Wed, 18 May 2022 12:29:40 -0700 [thread overview]
Message-ID: <20220518122940.6f4da4a8@kernel.org> (raw)
In-Reply-To: <d161164cbb1d048ce1b2d99d23ed87c605cfaa8c.camel@sipsolutions.net>
On Wed, 18 May 2022 20:59:21 +0200 Johannes Berg wrote:
> Acked-by: Johannes Berg <johannes@sipsolutions.net>
Thanks!
> Do you want me to follow up with trying to union the pointer into
> ml_priv?
>
> I prefer to union it rather than use ml_priv because we'll not want to
> use the getter everywhere when we already know, only on the boundaries.
Your call. Replacing all the direct references with a helper call could
indeed be onerous.
next prev parent reply other threads:[~2022-05-18 19:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-18 18:18 [PATCH net-next v2] net: ifdefy the wireless pointers in struct net_device Jakub Kicinski
2022-05-18 18:59 ` Johannes Berg
2022-05-18 19:29 ` Jakub Kicinski [this message]
2022-05-18 20:31 ` kernel test robot
2022-05-19 6:53 ` Sven Eckelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220518122940.6f4da4a8@kernel.org \
--to=kuba@kernel.org \
--cc=a@unstable.cc \
--cc=alex.aring@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=mareklindner@neomailbox.ch \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stefan@datenfreihafen.org \
--cc=sven@narfation.org \
--cc=sw@simonwunderlich.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).