* [PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open
@ 2022-05-18 6:20 Michael Trimarchi
2022-05-19 4:44 ` Jakub Kicinski
2022-05-19 9:50 ` patchwork-bot+netdevbpf
0 siblings, 2 replies; 3+ messages in thread
From: Michael Trimarchi @ 2022-05-18 6:20 UTC (permalink / raw)
To: Joakim Zhang, Liam Girdwood, Jakub Kicinski
Cc: Eric Dumazet, Paolo Abeni, netdev, linux-kernel
Make ndo_open less sensitive to memory pressure.
Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
---
Change:
- Adjust the commit message addressing the comments in RFC version
---
drivers/net/ethernet/freescale/fec_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/freescale/fec_main.c b/drivers/net/ethernet/freescale/fec_main.c
index 9f33ec838b52..09eb6ea9a584 100644
--- a/drivers/net/ethernet/freescale/fec_main.c
+++ b/drivers/net/ethernet/freescale/fec_main.c
@@ -3076,7 +3076,7 @@ fec_enet_alloc_rxq_buffers(struct net_device *ndev, unsigned int queue)
rxq = fep->rx_queue[queue];
bdp = rxq->bd.base;
for (i = 0; i < rxq->bd.ring_size; i++) {
- skb = netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE);
+ skb = __netdev_alloc_skb(ndev, FEC_ENET_RX_FRSIZE, GFP_KERNEL);
if (!skb)
goto err_alloc;
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open
2022-05-18 6:20 [PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open Michael Trimarchi
@ 2022-05-19 4:44 ` Jakub Kicinski
2022-05-19 9:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: Jakub Kicinski @ 2022-05-19 4:44 UTC (permalink / raw)
To: Michael Trimarchi
Cc: Joakim Zhang, Liam Girdwood, Eric Dumazet, Paolo Abeni, netdev,
linux-kernel
On Wed, 18 May 2022 08:20:07 +0200 Michael Trimarchi wrote:
> Make ndo_open less sensitive to memory pressure.
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
Reviewed-by: Jakub Kicinski <kuba@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open
2022-05-18 6:20 [PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open Michael Trimarchi
2022-05-19 4:44 ` Jakub Kicinski
@ 2022-05-19 9:50 ` patchwork-bot+netdevbpf
1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-19 9:50 UTC (permalink / raw)
To: Michael Trimarchi
Cc: qiangqing.zhang, lgirdwood, kuba, edumazet, pabeni, netdev,
linux-kernel
Hello:
This patch was applied to netdev/net-next.git (master)
by Paolo Abeni <pabeni@redhat.com>:
On Wed, 18 May 2022 08:20:07 +0200 you wrote:
> Make ndo_open less sensitive to memory pressure.
>
> Signed-off-by: Michael Trimarchi <michael@amarulasolutions.com>
> ---
> Change:
> - Adjust the commit message addressing the comments in RFC version
>
> [...]
Here is the summary with links:
- net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open
https://git.kernel.org/netdev/net-next/c/b885aab3d39d
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-19 9:50 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-18 6:20 [PATCH] net: fec: Avoid allocating rx buffer using ATOMIC in ndo_open Michael Trimarchi
2022-05-19 4:44 ` Jakub Kicinski
2022-05-19 9:50 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).