* regression: 'ctnetlink_dump_one_entry' defined but not used
@ 2022-05-19 9:06 Oliver Smith
2022-05-19 10:21 ` Florian Westphal
0 siblings, 1 reply; 4+ messages in thread
From: Oliver Smith @ 2022-05-19 9:06 UTC (permalink / raw)
To: Florian Westphal; +Cc: netdev, Harald Welte
Hi Florian,
since May 17 we see some automatic builds against net-next.git fail with:
> net/netfilter/nf_conntrack_netlink.c:1717:12: error: 'ctnetlink_dump_one_entry' defined but not used [-Werror=unused-function]
> 1717 | static int ctnetlink_dump_one_entry(struct sk_buff *skb,
> | ^~~~~~~~~~~~~~~~~~~~~~~~
Looks like this is a regression from your patch 8a75a2c17, I guess
ctnetlink_dump_one_entry needs #ifdef CONFIG_NF_CONNTRACK_EVENTS?
Best,
Oliver
--
- Oliver Smith <osmith@sysmocom.de> https://www.sysmocom.de/
=======================================================================
* sysmocom - systems for mobile communications GmbH
* Alt-Moabit 93
* 10559 Berlin, Germany
* Sitz / Registered office: Berlin, HRB 134158 B
* Geschaeftsfuehrer / Managing Director: Harald Welte
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: regression: 'ctnetlink_dump_one_entry' defined but not used
2022-05-19 9:06 regression: 'ctnetlink_dump_one_entry' defined but not used Oliver Smith
@ 2022-05-19 10:21 ` Florian Westphal
2022-05-19 20:13 ` Jakub Kicinski
0 siblings, 1 reply; 4+ messages in thread
From: Florian Westphal @ 2022-05-19 10:21 UTC (permalink / raw)
To: Oliver Smith; +Cc: Florian Westphal, netdev, Harald Welte
Oliver Smith <osmith@sysmocom.de> wrote:
> Hi Florian,
>
> since May 17 we see some automatic builds against net-next.git fail with:
>
> > net/netfilter/nf_conntrack_netlink.c:1717:12: error: 'ctnetlink_dump_one_entry' defined but not used [-Werror=unused-function]
> > 1717 | static int ctnetlink_dump_one_entry(struct sk_buff *skb,
> > | ^~~~~~~~~~~~~~~~~~~~~~~~
>
> Looks like this is a regression from your patch 8a75a2c17, I guess
> ctnetlink_dump_one_entry needs #ifdef CONFIG_NF_CONNTRACK_EVENTS?
Its fixed in nf-next.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: regression: 'ctnetlink_dump_one_entry' defined but not used
2022-05-19 10:21 ` Florian Westphal
@ 2022-05-19 20:13 ` Jakub Kicinski
2022-05-19 20:31 ` Pablo Neira Ayuso
0 siblings, 1 reply; 4+ messages in thread
From: Jakub Kicinski @ 2022-05-19 20:13 UTC (permalink / raw)
To: Pablo Neira Ayuso; +Cc: Florian Westphal, Oliver Smith, netdev, Harald Welte
On Thu, 19 May 2022 12:21:00 +0200 Florian Westphal wrote:
> Oliver Smith <osmith@sysmocom.de> wrote:
> > Hi Florian,
> >
> > since May 17 we see some automatic builds against net-next.git fail with:
> >
> > > net/netfilter/nf_conntrack_netlink.c:1717:12: error: 'ctnetlink_dump_one_entry' defined but not used [-Werror=unused-function]
> > > 1717 | static int ctnetlink_dump_one_entry(struct sk_buff *skb,
> > > | ^~~~~~~~~~~~~~~~~~~~~~~~
> >
> > Looks like this is a regression from your patch 8a75a2c17, I guess
> > ctnetlink_dump_one_entry needs #ifdef CONFIG_NF_CONNTRACK_EVENTS?
>
> Its fixed in nf-next.
Let's get it out to net-next, please, I'm carrying this patch locally
as well :(
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: regression: 'ctnetlink_dump_one_entry' defined but not used
2022-05-19 20:13 ` Jakub Kicinski
@ 2022-05-19 20:31 ` Pablo Neira Ayuso
0 siblings, 0 replies; 4+ messages in thread
From: Pablo Neira Ayuso @ 2022-05-19 20:31 UTC (permalink / raw)
To: Jakub Kicinski; +Cc: Florian Westphal, Oliver Smith, netdev, Harald Welte
On Thu, May 19, 2022 at 01:13:41PM -0700, Jakub Kicinski wrote:
> On Thu, 19 May 2022 12:21:00 +0200 Florian Westphal wrote:
> > Oliver Smith <osmith@sysmocom.de> wrote:
> > > Hi Florian,
> > >
> > > since May 17 we see some automatic builds against net-next.git fail with:
> > >
> > > > net/netfilter/nf_conntrack_netlink.c:1717:12: error: 'ctnetlink_dump_one_entry' defined but not used [-Werror=unused-function]
> > > > 1717 | static int ctnetlink_dump_one_entry(struct sk_buff *skb,
> > > > | ^~~~~~~~~~~~~~~~~~~~~~~~
> > >
> > > Looks like this is a regression from your patch 8a75a2c17, I guess
> > > ctnetlink_dump_one_entry needs #ifdef CONFIG_NF_CONNTRACK_EVENTS?
> >
> > Its fixed in nf-next.
>
> Let's get it out to net-next, please, I'm carrying this patch locally
> as well :(
I'll prepare a pull request asap.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-05-19 20:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-19 9:06 regression: 'ctnetlink_dump_one_entry' defined but not used Oliver Smith
2022-05-19 10:21 ` Florian Westphal
2022-05-19 20:13 ` Jakub Kicinski
2022-05-19 20:31 ` Pablo Neira Ayuso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).