netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: netdev@vger.kernel.org
Subject: GCC 12 warnings
Date: Thu, 19 May 2022 19:36:18 -0700	[thread overview]
Message-ID: <20220519193618.6539f9d9@kernel.org> (raw)

Hi Kees,

I'm sure you're involved in a number of glorious GCC 12 conversations..

We have a handful of drivers in networking which get hit by
-Warray-bounds because they allocate partial structures (I presume 
to save memory, misguided but more than 15min of work to refactor).

Since -Warray-bounds is included by default now this is making our
lives a little hard [1]. Is there a wider effort to address this?
If not do you have a recommendation on how to deal with it?

My best idea is to try to isolate the bad files and punt -Warray-bounds
to W=1 for those, so we can prevent more of them getting in but not
break WERROR builds on GCC 12. That said, I'm not sure how to achieve
that.. This for example did not work:

--- a/drivers/net/ethernet/mediatek/Makefile
+++ b/drivers/net/ethernet/mediatek/Makefile
@@ -9,5 +9,9 @@ mtk_eth-$(CONFIG_NET_MEDIATEK_SOC_WED) += mtk_wed.o
 ifdef CONFIG_DEBUG_FS
 mtk_eth-$(CONFIG_NET_MEDIATEK_SOC_WED) += mtk_wed_debugfs.o
 endif
 obj-$(CONFIG_NET_MEDIATEK_SOC_WED) += mtk_wed_ops.o
 obj-$(CONFIG_NET_MEDIATEK_STAR_EMAC) += mtk_star_emac.o
+
+ifneq ($(findstring 1, $(KBUILD_EXTRA_WARN)),)
+CFLAGS_mtk_ppe.o += -Wno-array-bounds
+endif

[1]
https://lore.kernel.org/all/20220520012555.2262461-1-kuba@kernel.org/

             reply	other threads:[~2022-05-20  2:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-20  2:36 Jakub Kicinski [this message]
2022-05-20 16:46 ` GCC 12 warnings Kees Cook
2022-05-20 17:23   ` Jakub Kicinski
2022-05-20 21:43     ` David Laight
2022-05-20 23:30       ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220519193618.6539f9d9@kernel.org \
    --to=kuba@kernel.org \
    --cc=keescook@chromium.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).