netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Moises Veleta <moises.veleta@linux.intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
	johannes@sipsolutions.net, ryazanov.s.a@gmail.com,
	loic.poulain@linaro.org, m.chetan.kumar@intel.com,
	chandrashekar.devegowda@intel.com, linuxwwan@intel.com,
	haijun.liu@mediatek.com, andriy.shevchenko@linux.intel.com,
	ilpo.jarvinen@linux.intel.com, ricardo.martinez@linux.intel.com,
	sreehari.kancharla@intel.com, dinesh.sharma@intel.com
Subject: Re: [PATCH net-next 1/1] net: wwan: t7xx: Add port for modem logging
Date: Fri, 20 May 2022 10:37:11 -0700	[thread overview]
Message-ID: <20220520103711.5f7f5b45@kernel.org> (raw)
In-Reply-To: <20220519182703.27056-1-moises.veleta@linux.intel.com>

On Thu, 19 May 2022 11:27:03 -0700 Moises Veleta wrote:
> +	ret = copy_from_user(skb_put(skb, actual_len), buf, actual_len);
> +	if (ret) {
> +		ret = -EFAULT;
> +		goto err_out;
> +	}
> +
> +	ret = t7xx_port_send_skb(port, skb, 0, 0);
> +	if (ret)
> +		goto err_out;

We don't allow using debugfs to pass random data from user space 
to firmware in networking. You need to find another way.

  parent reply	other threads:[~2022-05-20 17:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-19 18:27 [PATCH net-next 1/1] net: wwan: t7xx: Add port for modem logging Moises Veleta
2022-05-20  8:33 ` Kumar, M Chetan
2022-05-20 20:37   ` moises.veleta
2022-05-20 17:37 ` Jakub Kicinski [this message]
2022-05-20 17:42   ` moises.veleta
2022-05-20 17:48     ` Jakub Kicinski
2022-05-20 18:01       ` moises.veleta
2022-05-20 18:15         ` Jakub Kicinski
     [not found]           ` <dc07d0a9-793b-5b76-cf10-d8fad77c04ea@linux.intel.com>
     [not found]             ` <20220520144630.56841d21@kernel.org>
2022-05-20 22:00               ` moises.veleta
2022-05-24  5:11                 ` moises.veleta
2022-05-24 18:04                   ` Jakub Kicinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220520103711.5f7f5b45@kernel.org \
    --to=kuba@kernel.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=chandrashekar.devegowda@intel.com \
    --cc=davem@davemloft.net \
    --cc=dinesh.sharma@intel.com \
    --cc=haijun.liu@mediatek.com \
    --cc=ilpo.jarvinen@linux.intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linuxwwan@intel.com \
    --cc=loic.poulain@linaro.org \
    --cc=m.chetan.kumar@intel.com \
    --cc=moises.veleta@linux.intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=ricardo.martinez@linux.intel.com \
    --cc=ryazanov.s.a@gmail.com \
    --cc=sreehari.kancharla@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).