From: Jakub Kicinski <kuba@kernel.org>
To: "moises.veleta" <moises.veleta@linux.intel.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
johannes@sipsolutions.net, ryazanov.s.a@gmail.com,
loic.poulain@linaro.org, m.chetan.kumar@intel.com,
chandrashekar.devegowda@intel.com, linuxwwan@intel.com,
haijun.liu@mediatek.com, andriy.shevchenko@linux.intel.com,
ilpo.jarvinen@linux.intel.com, ricardo.martinez@linux.intel.com,
sreehari.kancharla@intel.com, dinesh.sharma@intel.com
Subject: Re: [PATCH net-next 1/1] net: wwan: t7xx: Add port for modem logging
Date: Fri, 20 May 2022 11:15:41 -0700 [thread overview]
Message-ID: <20220520111541.30c96965@kernel.org> (raw)
In-Reply-To: <09ce56a3-3624-13f9-6065-1367db5b8a6a@linux.intel.com>
On Fri, 20 May 2022 11:01:31 -0700 moises.veleta wrote:
> On 5/20/22 10:48, Jakub Kicinski wrote:
> > On Fri, 20 May 2022 10:42:56 -0700 moises.veleta wrote:
> >> Can we use debugfs to send an "on" or "off" commands, wherein the driver
> >> then sends special command sequences to the the firmware triggering the
> >> modem logging on and off?
> > On/off for all logging or for particular types of messages?
> > If it's for all logging can't the act of opening the debugfs
> > file be used as on "on" signal and closing as "off"?
> >
> > Where do the logging messages go?
>
> It would be "on/off" for all logging.
> Yes, opening the debugfs file can be used for "on" and closing for "off"
> without needing to use copy_from_user.
Sounds good. Can we also divert the actual logs so that they can be
read out of that debugfs file? That'd feel most natural to me..
> Logging messages would go to the relay interface file for consumption by
> a user application.
What's the relay interface? a special netdev? chardev? tty?
next prev parent reply other threads:[~2022-05-20 18:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 18:27 [PATCH net-next 1/1] net: wwan: t7xx: Add port for modem logging Moises Veleta
2022-05-20 8:33 ` Kumar, M Chetan
2022-05-20 20:37 ` moises.veleta
2022-05-20 17:37 ` Jakub Kicinski
2022-05-20 17:42 ` moises.veleta
2022-05-20 17:48 ` Jakub Kicinski
2022-05-20 18:01 ` moises.veleta
2022-05-20 18:15 ` Jakub Kicinski [this message]
[not found] ` <dc07d0a9-793b-5b76-cf10-d8fad77c04ea@linux.intel.com>
[not found] ` <20220520144630.56841d21@kernel.org>
2022-05-20 22:00 ` moises.veleta
2022-05-24 5:11 ` moises.veleta
2022-05-24 18:04 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520111541.30c96965@kernel.org \
--to=kuba@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=chandrashekar.devegowda@intel.com \
--cc=davem@davemloft.net \
--cc=dinesh.sharma@intel.com \
--cc=haijun.liu@mediatek.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=johannes@sipsolutions.net \
--cc=linuxwwan@intel.com \
--cc=loic.poulain@linaro.org \
--cc=m.chetan.kumar@intel.com \
--cc=moises.veleta@linux.intel.com \
--cc=netdev@vger.kernel.org \
--cc=ricardo.martinez@linux.intel.com \
--cc=ryazanov.s.a@gmail.com \
--cc=sreehari.kancharla@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).