From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0C811C433EF for ; Sat, 21 May 2022 00:26:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242045AbiEUA01 (ORCPT ); Fri, 20 May 2022 20:26:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45298 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229684AbiEUA0N (ORCPT ); Fri, 20 May 2022 20:26:13 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 907562253F for ; Fri, 20 May 2022 17:26:00 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 415F1B82E26 for ; Sat, 21 May 2022 00:25:59 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E019C385A9; Sat, 21 May 2022 00:25:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653092757; bh=1/DZWmvoYDHPTJcAGOk6LAXSXfio2WDcSEGRCHBiIDk=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=G9YtqjKpTdex2JIUiuxja2G588CbFdovYHNtq2M9+x2+z9+7337vYH03LCKm5BV9P n8lgylRFWDckD8T5nupqGwrwHfVNRMUdQXcMAalm6wwgHteZH8+nj8SQX+t7bDp+xu qbZuGybX0RYnsHMh+m+veEftM8ayj8ti8K9ymWRymv5i58g/PB1f2C4taNZAfFDy8y CCOkV/fNIQUSo/Z4VH9X+3AIB0PQDN2At3+8wo/GGkSO9uA1L2+9c5bgtrWfGeeHMt xhXIaZfwUVqyWrleV4FMx41ifyBgCuXzFySiP/VFiB8pVwS9w+bV60SD1nzbnjVUd/ DnQoWZhFsFWeA== Date: Fri, 20 May 2022 17:25:56 -0700 From: Jakub Kicinski To: Loic Poulain Cc: Ziyang Xuan , chandrashekar.devegowda@intel.com, linuxwwan@intel.com, chiranjeevi.rapolu@linux.intel.com, haijun.liu@mediatek.com, m.chetan.kumar@linux.intel.com, ricardo.martinez@linux.intel.com, ryazanov.s.a@gmail.com, johannes@sipsolutions.net, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, netdev@vger.kernel.org Subject: Re: [PATCH net-next v3] net: wwan: t7xx: fix GFP_KERNEL usage in spin_lock context Message-ID: <20220520172556.1d62b899@kernel.org> In-Reply-To: References: <20220519074351.829774-1-william.xuanziyang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, 19 May 2022 09:29:12 +0200 Loic Poulain wrote: > On Thu, 19 May 2022 at 09:26, Ziyang Xuan wrote: > > > > t7xx_cldma_clear_rxq() call t7xx_cldma_alloc_and_map_skb() in spin_lock > > context, But __dev_alloc_skb() in t7xx_cldma_alloc_and_map_skb() uses > > GFP_KERNEL, that will introduce scheduling factor in spin_lock context. > > > > Because t7xx_cldma_clear_rxq() is called after stopping CLDMA, so we can > > remove the spin_lock from t7xx_cldma_clear_rxq(). > > > > Fixes: 39d439047f1d ("net: wwan: t7xx: Add control DMA interface") > > Suggested-by: Ricardo Martinez > > Signed-off-by: Ziyang Xuan > > Reviewed-by: Loic Poulain Wait, you reviewed two different fixes for the same issue? Please say something when that happens I thought both are needed :/