From: Saeed Mahameed <saeedm@nvidia.com>
To: Guan Jing <guanjing6@huawei.com>
Cc: davem@davemloft.net, leon@kernel.org, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -next] net/mlx5: Fix build error of multiple definition
Date: Fri, 20 May 2022 15:12:45 -0700 [thread overview]
Message-ID: <20220520221245.bsf3abwo566l3yzs@sx1> (raw)
In-Reply-To: <20220520073423.35556-1-guanjing6@huawei.com>
On 20 May 15:34, Guan Jing wrote:
>There are some errors like:
>
>drivers/net/ethernet/mellanox/mlx5/core/lag/lag.o:
>In function `mlx5_lag_mpesw_init':
>lag.c:(.text+0xb70): multiple definition of `mlx5_lag_mpesw_init'
>drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.o:debugfs.c:(.text+0x440):
>first defined here
>drivers/net/ethernet/mellanox/mlx5/core/lag/lag.o: In function `mlx5_lag_mpesw_cleanup':
>lag.c:(.text+0xb80): multiple definition of `mlx5_lag_mpesw_cleanup'
>drivers/net/ethernet/mellanox/mlx5/core/lag/debugfs.o:debugfs.c:(.text+0x450):
>first defined here
>
>So, add 'static inline' on the defineation of these functions.
Already fixed by:
commit d935053a62fa11d06c757c1725782e46e7e823db
Author: Jakub Kicinski <kuba@kernel.org>
Date: Wed May 18 11:30:22 2022 -0700
net/mlx5: fix multiple definitions of mlx5_lag_mpesw_init / mlx5_lag_mpesw_cleanup
Thanks.
prev parent reply other threads:[~2022-05-20 22:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-20 7:34 [PATCH -next] net/mlx5: Fix build error of multiple definition Guan Jing
2022-05-20 22:12 ` Saeed Mahameed [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220520221245.bsf3abwo566l3yzs@sx1 \
--to=saeedm@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=guanjing6@huawei.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox