From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EFEDCC433EF for ; Sat, 21 May 2022 11:30:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239812AbiEULaI (ORCPT ); Sat, 21 May 2022 07:30:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36184 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1355913AbiEULW1 (ORCPT ); Sat, 21 May 2022 07:22:27 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A563344F1; Sat, 21 May 2022 04:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1653131802; x=1684667802; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=5KFm4isvsGqNpJBUH/v9LUn20VCp8JnS7lgpH6kfS64=; b=lubdR4kl5GI1eOAf4LZyvWrWK3wnLh1rnatcErpSWwa2EpdDkQDJuyG3 KzzPLcK4a3cfuj8lyRF3gPBzVj7C1+fKngJny3UKI1GWTS7S3lILvnBxv B8aue4wAlCllrrjrWVk6zz0ftYGZWwlbk6hr+sCP09jFj4v1tdnA9JtSW NKQnvn/jpbluGQjD325SffOAacSPdmFwEnCePDRvnp9axoOvlQ6euO0k9 VjGMuYCIS8p2s4NwOrKCLAGqS+/a4F37mKcy0+GWnEhPE2MJd5OOu6LSw +Zrn3yDvfXWaUOeSTjQp6zFTVFChaJoIslk6DYWTGSGZiwXumP1ZneQUl Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10353"; a="298154148" X-IronPort-AV: E=Sophos;i="5.91,242,1647327600"; d="scan'208";a="298154148" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 May 2022 04:16:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,242,1647327600"; d="scan'208";a="640699541" Received: from lkp-server02.sh.intel.com (HELO 242b25809ac7) ([10.239.97.151]) by fmsmga004.fm.intel.com with ESMTP; 21 May 2022 04:16:37 -0700 Received: from kbuild by 242b25809ac7 with local (Exim 4.95) (envelope-from ) id 1nsN64-0006EE-GG; Sat, 21 May 2022 11:16:36 +0000 Date: Sat, 21 May 2022 19:16:00 +0800 From: kernel test robot To: Yosry Ahmed , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Song Liu , Yonghong Song , John Fastabend , KP Singh , Hao Luo , Tejun Heo , Zefan Li , Johannes Weiner , Shuah Khan , Roman Gushchin , Michal Hocko Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org, Stanislav Fomichev , David Rientjes , Greg Thelen , Shakeel Butt , linux-kernel@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, cgroups@vger.kernel.org, Yosry Ahmed Subject: Re: [PATCH bpf-next v1 1/5] cgroup: bpf: add a hook for bpf progs to attach to rstat flushing Message-ID: <202205211949.sJimC9kh-lkp@intel.com> References: <20220520012133.1217211-2-yosryahmed@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220520012133.1217211-2-yosryahmed@google.com> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi Yosry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on bpf-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Yosry-Ahmed/bpf-rstat-cgroup-hierarchical-stats/20220520-093041 base: https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master config: hexagon-randconfig-r041-20220519 (https://download.01.org/0day-ci/archive/20220521/202205211949.sJimC9kh-lkp@intel.com/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e00cbbec06c08dc616a0d52a20f678b8fbd4e304) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/23c4c48fb35b084dc1173c7b9d23d4e6e1a084a3 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Yosry-Ahmed/bpf-rstat-cgroup-hierarchical-stats/20220520-093041 git checkout 23c4c48fb35b084dc1173c7b9d23d4e6e1a084a3 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash kernel/cgroup/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot All warnings (new ones prefixed by >>): >> kernel/cgroup/rstat.c:145:22: warning: no previous prototype for function 'bpf_rstat_flush' [-Wmissing-prototypes] __weak noinline void bpf_rstat_flush(struct cgroup *cgrp, ^ kernel/cgroup/rstat.c:145:17: note: declare 'static' if the function is not intended to be used outside of this translation unit __weak noinline void bpf_rstat_flush(struct cgroup *cgrp, ^ static 1 warning generated. vim +/bpf_rstat_flush +145 kernel/cgroup/rstat.c 143 144 /* A hook for bpf stat collectors to attach to and flush their stats */ > 145 __weak noinline void bpf_rstat_flush(struct cgroup *cgrp, 146 struct cgroup *parent, int cpu) 147 { 148 } 149 -- 0-DAY CI Kernel Test Service https://01.org/lkp