From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E105C433F5 for ; Mon, 23 May 2022 15:58:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238270AbiEWP6C (ORCPT ); Mon, 23 May 2022 11:58:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238367AbiEWP5F (ORCPT ); Mon, 23 May 2022 11:57:05 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADC7D58381; Mon, 23 May 2022 08:57:04 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 25F026135B; Mon, 23 May 2022 15:57:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B4B5C385A9; Mon, 23 May 2022 15:57:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1653321423; bh=ujayOaH3fjlY8iDthmcKzv6/JmxtEhUomVjdt+Jmwgg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tgvNPMWMR0DgzsbPzEbFoxMDB6bdBKwsJmcScuoqzOwqN+32MpayMUKnszr1vvDNH l1dNRJ9hbfmHRFzD7jtjyds1SkEHNlimzj9CStprKh0i+R/oDYFJmlGy9a9TgxoCWw dLxgF12dvdatwSZ80zFFuMAl87xArpCNvUe41bOJNcy5uZxC566UrFd3dPN1DjM08g rtN/sRNCqfsvUYYrltioDX8YXqbmOZJUulbNryeZ1gkTeXg9Myw+BEKoWo0r1JqEQt 86PYjA6OY3tcKv7rMypvwqRShwXKW3lUXvscf711eUT4gmfSKjNQKhfWWs492B4W5D C8inFW3952WjQ== Date: Mon, 23 May 2022 08:57:01 -0700 From: Jakub Kicinski To: Ping-Ke Shih Cc: "kvalo@kernel.org" , "johannes@sipsolutions.net" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "keescook@chromium.org" , "colin.king@intel.com" Subject: Re: [PATCH net-next 3/8] wifi: rtlwifi: remove always-true condition pointed out by GCC 12 Message-ID: <20220523085701.3d7550ff@kernel.org> In-Reply-To: <8fb9d491692a4a2dabe783ffefc76ded@realtek.com> References: <20220520194320.2356236-1-kuba@kernel.org> <20220520194320.2356236-4-kuba@kernel.org> <8fb9d491692a4a2dabe783ffefc76ded@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 23 May 2022 02:35:32 +0000 Ping-Ke Shih wrote: > This is a typo since initial commit. Correct it by > - value[0] != NULL) > + value[0][0] != 0) > > So, NACK this patch. Too, late, the patches were already applied, sorry. Please post a fixup.